[
https://issues.apache.org/jira/browse/IGNITE-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574186#comment-17574186
]
Andrey N. Gura commented on IGNITE-17398:
-----------------------------------------
Tags/labels convenience is not free. Prometheus developers warn about it: [Do
not overuse
labels|https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels].
Moreover, the OpenCensus exporter produces a lot of garbage due to a text
nature of metrics format. Adding tags will significantly increase GC pressure
and size of exported data.
So, from my point of view, we should not add tags/labels. It looks like
convenience vs Ignite stability and performance.
> Opencensus metrics do not work well with Prometheus since it do not have tags
> -----------------------------------------------------------------------------
>
> Key: IGNITE-17398
> URL: https://issues.apache.org/jira/browse/IGNITE-17398
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.9.1
> Reporter: Sergey Kadaner
> Priority: Major
> Labels: metrics
> Attachments: image-2022-07-20-17-51-07-217.png
>
>
> The metrics created by the [new metrics
> system|https://ignite.apache.org/docs/latest/monitoring-metrics/new-metrics]
> are very inconvenient to use with Prometheus since it does not use tags.
> For example, Spring metric generated for the same cache looks like the
> following in Prometheus and is very convenient to use:
>
> {noformat}
> cache_gets_total{cache="MY_CACHE_NAME",name="MY_CACHE_NAME",result="hit",}
> 1387.0{noformat}
>
> The native Ignite metric looks like the following:
>
> {noformat}
> cache_MY_CACHE_NAME_CacheHits 1387.0{noformat}
> The Spring reported statistics can be easily filtered by cache name and other
> attributes, while the build-in Ignite metrics do not provide an easy way to
> access cache names. The only option seems to be parsing the
> "cache_MY_CACHE_NAME_CacheHits" strings which AFAIK is not supported by
> Grafana.
>
> For example with tags it is very easy to get a graph in Grafana with a cache
> hit percentage that includes every existing cache. It automatically extracts
> the cache name from the "cache" tag. Unfortunately, it is not possible if
> there are no tags.
> !image-2022-07-20-17-51-07-217.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
