[ https://issues.apache.org/jira/browse/IGNITE-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609510#comment-17609510 ]
Ivan Bessonov commented on IGNITE-17728: ---------------------------------------- Looks good to me! > Improve data size-related metrics > --------------------------------- > > Key: IGNITE-17728 > URL: https://issues.apache.org/jira/browse/IGNITE-17728 > Project: Ignite > Issue Type: Improvement > Reporter: Aleksandr Polovtcev > Assignee: Aleksandr Polovtcev > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There are several problems with the current approach to metrics related to > pages and sizes occupied by data: > # {{PagesFillFactor}} implementation is strange: though its javadoc is pretty > much useless, one might think that it represents a percentage of bytes > occupied by data in relation to the whole available bytes. However, for some > reason, it is calculated as {{(TotalSpace - FreeSpaceInDataPages) / > TotalSpace}}, i.e. it does not take completely empty pages into account. > # There exists a {{TotalUsedPages}} metric that is only available through > JMX, it does not get registered in the MetricsRegistry. > # There exists {{TotalAllocatedPages}} and {{TotalAllocatedSize}} metrics, > but no {{TotalUsedSize}} metrics. > # It would be helpful to add a metric that calculates bytes, occupied by the > data (even though it can be indirectly computed using the > {{PagesFillFactor}}). -- This message was sent by Atlassian Jira (v8.20.10#820010)