[
https://issues.apache.org/jira/browse/IGNITE-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611076#comment-17611076
]
Simon Ochsenreither edited comment on IGNITE-11461 at 9/29/22 4:56 PM:
-----------------------------------------------------------------------
It's kinda hard to expect a mass migration on one hand while needlessly
[creating new
conflicts|https://github.com/apache/ignite/tree/master/modules/kubernetes/src/main/java/org/apache/ignite/client]
on the other.
Trying to fix ignite-kubernetes:
{code}
Index: modules/kubernetes/src/main/java/module-info.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/modules/kubernetes/src/main/java/module-info.java
b/modules/kubernetes/src/main/java/module-info.java
new file mode 100644
--- /dev/null (date 1664468172190)
+++ b/modules/kubernetes/src/main/java/module-info.java (date 1664468172190)
@@ -0,0 +1,6 @@
+module org.apache.ignite.kubernetes {
+ requires org.apache.ignite.core;
+
+ requires com.fasterxml.jackson.annotation;
+ requires com.fasterxml.jackson.databind;
+}
Index:
modules/kubernetes/src/main/java/org/apache/ignite/client/ThinClientKubernetesAddressFinder.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git
a/modules/kubernetes/src/main/java/org/apache/ignite/client/ThinClientKubernetesAddressFinder.java
b/modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/client/ThinClientKubernetesAddressFinder.java
rename from
modules/kubernetes/src/main/java/org/apache/ignite/client/ThinClientKubernetesAddressFinder.java
rename to
modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/client/ThinClientKubernetesAddressFinder.java
---
a/modules/kubernetes/src/main/java/org/apache/ignite/client/ThinClientKubernetesAddressFinder.java
(revision 996e1ad4361f0d9dc8974689ddf6931c56ab5083)
+++
b/modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/client/ThinClientKubernetesAddressFinder.java
(date 1664468060678)
@@ -15,8 +15,9 @@
* limitations under the License.
*/
-package org.apache.ignite.client;
+package org.apache.ignite.kubernetes.client;
+import org.apache.ignite.client.ClientAddressFinder;
import
org.apache.ignite.internal.kubernetes.connection.KubernetesServiceAddressResolver;
import
org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
Index:
modules/kubernetes/src/test/java/org/apache/ignite/kubernetes/discovery/TestClusterClientConnection.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git
a/modules/kubernetes/src/test/java/org/apache/ignite/kubernetes/discovery/TestClusterClientConnection.java
b/modules/kubernetes/src/test/java/org/apache/ignite/kubernetes/discovery/TestClusterClientConnection.java
---
a/modules/kubernetes/src/test/java/org/apache/ignite/kubernetes/discovery/TestClusterClientConnection.java
(revision 996e1ad4361f0d9dc8974689ddf6931c56ab5083)
+++
b/modules/kubernetes/src/test/java/org/apache/ignite/kubernetes/discovery/TestClusterClientConnection.java
(date 1664468060690)
@@ -20,7 +20,7 @@
import org.apache.ignite.Ignition;
import org.apache.ignite.client.ClientCache;
import org.apache.ignite.client.IgniteClient;
-import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.kubernetes.client.ThinClientKubernetesAddressFinder;
import org.apache.ignite.configuration.ClientConfiguration;
import org.apache.ignite.configuration.ClientConnectorConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
Index: modules/core/src/main/java/module-info.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/modules/core/src/main/java/module-info.java
b/modules/core/src/main/java/module-info.java
new file mode 100644
--- /dev/null (date 1664470741994)
+++ b/modules/core/src/main/java/module-info.java (date 1664470741994)
@@ -0,0 +1,10 @@
+module org.apache.ignite.core {
+ requires static org.jetbrains.annotations;
+
+
+ exports org.apache.ignite;
+ exports org.apache.ignite.client;
+ exports org.apache.ignite.configuration;
+ exports org.apache.ignite.internal;
+ exports org.apache.ignite.internal.util.typedef.internal;
+}
{code}
was (Author: soc):
It's kinda hard to expect a mass migration on one hand while needlessly
[creating new
conflicts|https://github.com/apache/ignite/tree/master/modules/kubernetes/src/main/java/org/apache/ignite/client]
on the other.
> Automatic modules support for Apache Ignite: find and resolve packages
> conflicts
> --------------------------------------------------------------------------------
>
> Key: IGNITE-11461
> URL: https://issues.apache.org/jira/browse/IGNITE-11461
> Project: Ignite
> Issue Type: Improvement
> Reporter: Dmitry Pavlov
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Example of failure in a modular environment:
> Error:java: the unnamed module reads package
> org.apache.ignite.internal.processors.cache.persistence.file from both
> ignite.core and ignite.direct.io
> This type of failure is named package inference, but it is strictly
> prohibited
> http://openjdk.java.net/projects/jigsaw/spec/reqs/#non-interference
> Ignite compatibility with Jigsaw is tested in a separate project. See details
> in
> https://github.com/apache/ignite/tree/ignite-11461-java11/modules/dev-utils/ignite-modules-test#ignite-modular-environment-test-project
>
> Following table contains currenly investigated Ignite modules if this
> applicability as automatic modules:
> ||Module||Run In Modular Environment||Changeable using private API only ||
> Notes ||
> |ignite-code|(/)|(/)| |
> |ignite-indexing|(x) [IGNITE-11464] | (?) Refacrtoing to use
> ignite-indexing-text may be a breaking change | Lucene artifacts exclusion is
> required by user manually. |
> |ignite-compress | (x) | (/) not releaseed |
> org.apache.ignite.internal.processors.compress package conflict |
> |ignite-direct-io|(x) blocked by indexind | (/) |
> org.apache.ignite.internal.processors.cache.persistence.file package conflict
> |
> |ignite-spring|(x) [IGNITE-11467] blocked by indexing | (x)
> org.apache.ignite.IgniteSpringBean affected | |
> |ignite-ml |(x) blocked by indexing | | |
> |ignite-log4j|(/)|(/) | But may not compile with other logging dependencies -
> EOL https://blogs.apache.org/logging/entry/moving_on_to_log4j_2 |
> |ignite-log4j2|(/)|(/)| |
> |ignite-slf4j | (/)|(/)| |
> |ignite-rest-http | (x) IGNITE-11469 & Mirgate to log4j2x [IGNITE-11486] |
> (/) | Usage with slf4j may break compilation because conflict of packages |
> |ignite-hibernate_5.3 and others | (x) [IGNITE-11485] | (?) | avoid of API
> breaking is possibleif hibernate core classes not used by third party code |
> |ignite-zookeeper| (x) IGNITE-11486 | (/) | |
> |ignite-spring-data_2-0 | (x) blocked by spring | org.apache.commons.logging
> from both commons.logging and spring.jcl conflict |
> https://jira.spring.io/browse/SPR-16605 |
> |ignite-ml | (/) master (x) 2.7 | | |
> |ignite-cassandra-store | (x) [IGNITE-11467] blocked by spring | (/) |
> Only spring needs to be fixed |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
