[
https://issues.apache.org/jira/browse/IGNITE-17865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627715#comment-17627715
]
Anton Vinogradov edited comment on IGNITE-17865 at 11/2/22 1:39 PM:
--------------------------------------------------------------------
[~slava.koptilin]
{code:java}
Starting rebalance routine [cache, topVer=AffinityTopologyVersion [topVer=4,
minorTopVer=0], supplier=d822f1cd-f36e-4be3-bb4c-c7a80b700000,
fullPartitions=[0-511], histPartitions=[], rebalanceId=1]
{code}
1) 0-511 will never happen. Even 0-4,9-15,etc.
It's imposible to have sequence longer than 3 in real world.
Such optimisation does nothing heplful in real world.
2) How are you going to search for partition's 433 fate in this case?
3) As to the property.
Okey, you turned it on. Sh*t happened, and we're now at question number 2.
was (Author: av):
[~slava.koptilin]
{code:java}
Starting rebalance routine [cache, topVer=AffinityTopologyVersion [topVer=4,
minorTopVer=0], supplier=d822f1cd-f36e-4be3-bb4c-c7a80b700000,
fullPartitions=[0-511], histPartitions=[], rebalanceId=1]
{code}
1) 0-511 will never happen. Even 0-4,9-15,etc.
It's imposible to have sequence longer than 3 in real world.
Such optimisation does nothing heplful in real world.
2) How are you going to serch for partition's 433 fate in this case?
3) As to the property.
Okey, you turned it on. Sh*t happened, and we're now at question number 2.
> Disable partition ranges in log messages about rebalance or PME
> ---------------------------------------------------------------
>
> Key: IGNITE-17865
> URL: https://issues.apache.org/jira/browse/IGNITE-17865
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Minor
> Labels: ise, newbie
> Attachments: replicated.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When you need to analyze cases of partitions inconsistency, full list of
> partitions is needed, but there is an optimization which replaces list of
> consecutive partitions with ranges. So, as you can see below, we can not find
> partition 2 by simple text search:
> {quote}2021-08-11 23:12:11.338 [WARN
> ][sys-#213|#213][org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtPartitionTopologyImpl]
> Partitions have been scheduled for rebalancing due to outdated update
> counter [grp=group, readyTopVer=AffinityTopologyVersion [topVer=33,
> minorTopVer=0], topVer=AffinityTopologyVersion [topVer=33, minorTopVer=0],
> nodeId=8e05997a-4ff7-4fdb-9480-cfbcefa8bbf5,
> partsFull=[{color:#ff0000}*1-3*{color}, ...], partsHistorical=[]]
> {quote}
> {quote}2021-08-11 23:12:11.338 [WARN
> ][sys-#213|#213][org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture]
> Partitions weren't present in any history reservation: [[[grp=grp2
> part=[[{color:#ff0000}*1-3*{color}]]]
> {quote}
> We need to remove this optimization, because it can lead to mistakes in logs
> analysis.
> Partition ranges are formed in _GridToStringBuilder#compact_ method, which is
> used to log of partition lists (except one place with exception and tests).
> Below are such places (without usages in tests):
> # {_}GridClientPartitionTopology#resetOwners{_}:
> [L1311|https://github.com/apache/ignite/blob/8ec5d50896a2b5f2d008d0bb8f67f7f3d7cdf584/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java#L1311],
>
> [L1312|https://github.com/apache/ignite/blob/8ec5d50896a2b5f2d008d0bb8f67f7f3d7cdf584/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridClientPartitionTopology.java#L1312]
> (WARN)
> # {_}GridDhtPartitionDemander#handleSupplyMessage{_}:
> [L561|https://github.com/apache/ignite/blob/147e03177aeadee03cb4925649c03633ce6be192/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java#L561]
> (ERROR)
> # {_}GridDhtPartitionDemander.RebalanceFuture#requestPartitions0{_}:
> [L1434|https://github.com/apache/ignite/blob/147e03177aeadee03cb4925649c03633ce6be192/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java#L1434],
>
> [L1435|https://github.com/apache/ignite/blob/147e03177aeadee03cb4925649c03633ce6be192/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java#L1435]
> (INFO)
> # {_}GridDhtPartitionsExchangeFuture#printPartitionRebalancingFully{_}:
> [L4282|https://github.com/apache/ignite/blob/bc843a5b40a6da0e2bfcb77857bea499ab9a4512/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java#L4282]
> (INFO)
> # {_}GridDhtPartitionSupplier#handleDemandMessage{_}:
> [L276|https://github.com/apache/ignite/blob/00988d20af19485585e98e885c610a704640c083/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionSupplier.java#L276]
> (DEBUG)
> # {_}GridDhtPartitionTopologyImpl#detectLostPartitions{_}:
> [L2281|https://github.com/apache/ignite/blob/8ec5d50896a2b5f2d008d0bb8f67f7f3d7cdf584/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java#L2281]
> (WARN)
> # {_}GridDhtPartitionTopologyImpl#resetOwners{_}:
> [L2445|https://github.com/apache/ignite/blob/8ec5d50896a2b5f2d008d0bb8f67f7f3d7cdf584/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionTopologyImpl.java#L2445]
> (WARN)
> # {_}PartitionsEvictManager{_}: called in _#toString_ at
> [L254|https://github.com/apache/ignite/blob/9021f783e9453375482c9b255a42ca827e091daa/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionsEvictManager.java#L254],
> result used in _#showProgress_ at
> [L199|https://github.com/apache/ignite/blob/9021f783e9453375482c9b255a42ca827e091daa/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionsEvictManager.java#L199]
> (INFO)
> # {_}SnapshotFutureTask#onMarkCheckpointBegin{_}:
> [L400|https://github.com/apache/ignite/blob/52121c2e4d4792e92748f15f0d58bc22b7f2259e/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java#L400]
> (in exception message),
> [L409|https://github.com/apache/ignite/blob/52121c2e4d4792e92748f15f0d58bc22b7f2259e/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java#L409]
> (WARN)
> # {_}SnapshotFutureTask{_}: called in _#compactGroupPartitions_ at
> [L661|https://github.com/apache/ignite/blob/52121c2e4d4792e92748f15f0d58bc22b7f2259e/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java#L661],
> result used in _#onCheckpointBegin_ at
> [L468|https://github.com/apache/ignite/blob/52121c2e4d4792e92748f15f0d58bc22b7f2259e/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFutureTask.java#L468]
> (INFO)
> # {_}SnapshotRestoreProcess{_}: called in _#partitionsMapToCompactString_ at
> [L1370|https://github.com/apache/ignite/blob/52121c2e4d4792e92748f15f0d58bc22b7f2259e/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java#L1370],
> result used in _#preload_ at
> [L1001|https://github.com/apache/ignite/blob/52121c2e4d4792e92748f15f0d58bc22b7f2259e/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java#L1001]
> (INFO)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
