[ 
https://issues.apache.org/jira/browse/IGNITE-17733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638751#comment-17638751
 ] 

Vladislav Pyatkov commented on IGNITE-17733:
--------------------------------------------

LGTM

> Change lock manager implementation
> ----------------------------------
>
>                 Key: IGNITE-17733
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17733
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Vladislav Pyatkov
>            Assignee: Denis Chudov
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> *Motivation:*
> Lock manager should be based on _Wait-Die_ deadlock resolution strategy by 
> default. The conception is implemented in 
> [POC|https://github.com/ascherbakoff/ai3-txn-mvp].
> Since current implementation has another resolution strategy, some tests will 
> become failing. All those test should to be fixed as a part of the ticket.
> *Definition of Done:*
> Required to replace implementation of _HeapLockManager_ to [_Lock_ 
> |https://github.com/ascherbakoff/ai3-txn-mvp/blob/main/src/main/java/com/ascherbakoff/ai3/lock/Lock.java]
>  and adjusted API. 
> Hence, the lock resolution strategy is changed, it leads to failing of tests 
> from _AbstractLockManagerTest_ and _TxAbstractTest_. These failings have to 
> be fixed.
> Property IGNITE_ALL_LOCK_TYPES_ARE_USED should be removed.
> *Workaround:*
> Until, this issue does not be fixed, we use lock only on primary keys. This 
> behavior is turned by property IGNITE_ALL_LOCK_TYPES_ARE_USED.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to