[ 
https://issues.apache.org/jira/browse/IGNITE-19381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mirza Aliev updated IGNITE-19381:
---------------------------------
    Description: 
h3. Motivation

While HybridTimestamp refactoring [~ibessonov] noticed that RW related messages 
might have null as a timestamp that seems to be incorrect. Probably we've 
missed 
{code:java}
.timestampLong(clock.nowLong());{code}
within some RW  messages, e.g. while building 
ReadWriteScanRetrieveBatchReplicaRequest.
h3. Definition of done

Thus it's required to:
 * add timestampLong() wherever needed.
 * add assertion that will check that TimestampAware messages have @NotNull 
timestamp field.
 * replace "nullableHybridTimestamp(...)" call with "hybridTimestamp(...), etc. 

 

  was:
h3. Motivation

While HybridTimestamp refactoring [~ibessonov] noticed that RW related messages 
might have null as a timestamp that seems to be incorrect. Probably we've 
missed 
{code:java}
.timestampLong(clock.nowLong());{code}
within some RW  messages, e.g. while building 
ReadWriteScanRetrieveBatchReplicaRequest.
h3. Definition of done

Thus it's required to:
 * add imestampLong() wherever needed.
 * add assertion that will check that TimestampAware messages have @NotNull 
timestamp field.
 * replace "nullableHybridTimestamp(...)" call with "hybridTimestamp(...), etc. 

 


> TimestampAware messages sometimes lacks timestamps
> --------------------------------------------------
>
>                 Key: IGNITE-19381
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19381
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Alexander Lapin
>            Priority: Blocker
>              Labels: ignite-3
>
> h3. Motivation
> While HybridTimestamp refactoring [~ibessonov] noticed that RW related 
> messages might have null as a timestamp that seems to be incorrect. Probably 
> we've missed 
> {code:java}
> .timestampLong(clock.nowLong());{code}
> within some RW  messages, e.g. while building 
> ReadWriteScanRetrieveBatchReplicaRequest.
> h3. Definition of done
> Thus it's required to:
>  * add timestampLong() wherever needed.
>  * add assertion that will check that TimestampAware messages have @NotNull 
> timestamp field.
>  * replace "nullableHybridTimestamp(...)" call with "hybridTimestamp(...), 
> etc. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to