[ 
https://issues.apache.org/jira/browse/IGNITE-19699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Pereslegin updated IGNITE-19699:
--------------------------------------
    Description: 
Currently InternalTable interface has 5 scan(...) methods.

The following 2 methods are currently only used in tests.
{code:java}
Publisher<BinaryRow> scan(int partId, @Nullable InternalTransaction tx)
{code}
{code:java}
Publisher<BinaryRow> scan(
            int partId,
            @Nullable InternalTransaction tx,
            @Nullable Integer indexId,
            @Nullable BinaryTuplePrefix lowerBound,
            @Nullable BinaryTuplePrefix upperBound,
            int flags,
            @Nullable BitSet columnsToInclude
    ); {code}
We must try to get rid of them.
Tests that use explicit transaction methods should be reworked using other 
methods (which use either the RW transaction's txId or RO transaction's 
timestamp),

Also consider changing the {{ClusterNode}} to the name of the node in the 
{{{}PrimaryReplica{}}}.

  was:
Currently InternalTable has 5 scan(...) methods.

The following 2 methods are currently only used in tests.
{code:java}
Publisher<BinaryRow> scan(int partId, @Nullable InternalTransaction tx)
{code}
{code:java}
Publisher<BinaryRow> scan(
            int partId,
            @Nullable InternalTransaction tx,
            @Nullable Integer indexId,
            @Nullable BinaryTuplePrefix lowerBound,
            @Nullable BinaryTuplePrefix upperBound,
            int flags,
            @Nullable BitSet columnsToInclude
    ); {code}
We must try to get rid of them.
Tests that use explicit transaction methods should be reworked using other 
methods (which use either the RW transaction's txId or RO transaction's 
timestamp),

Also consider changing the {{ClusterNode}} to the name of the node in the 
{{{}PrimaryReplica{}}}.


> Clean up InternalTable.
> -----------------------
>
>                 Key: IGNITE-19699
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19699
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Pavel Pereslegin
>            Priority: Minor
>
> Currently InternalTable interface has 5 scan(...) methods.
> The following 2 methods are currently only used in tests.
> {code:java}
> Publisher<BinaryRow> scan(int partId, @Nullable InternalTransaction tx)
> {code}
> {code:java}
> Publisher<BinaryRow> scan(
>             int partId,
>             @Nullable InternalTransaction tx,
>             @Nullable Integer indexId,
>             @Nullable BinaryTuplePrefix lowerBound,
>             @Nullable BinaryTuplePrefix upperBound,
>             int flags,
>             @Nullable BitSet columnsToInclude
>     ); {code}
> We must try to get rid of them.
> Tests that use explicit transaction methods should be reworked using other 
> methods (which use either the RW transaction's txId or RO transaction's 
> timestamp),
> Also consider changing the {{ClusterNode}} to the name of the node in the 
> {{{}PrimaryReplica{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to