[ 
https://issues.apache.org/jira/browse/IGNITE-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348205#comment-15348205
 ] 

Vladimir Ozerov edited comment on IGNITE-3328 at 6/24/16 12:44 PM:
-------------------------------------------------------------------

Pavel,

My comments:
1) I would hide {{AffintiyFunctionBase}} in internal namespace. Otherwise 
potential implementors will try using it.
2) I do not see why do we need {{IAffinityFunctionContext}}. This is our 
internal thing, and user will never implement it in his own.
3) Coding quidelines are not respected in Java. Missing empty lines between 
semantically different lines, incorrect { placement (.Net style instead of Java 
style).

Vladimir.


was (Author: vozerov):
Pavel,

My comments:
1) I would hide {{AffintiyFunctionBase}} in internal namespace. Otherwise 
potential implementors will try using it.
2) I do not see why do we need {{IAffinityFunctionContext}}. This is just some 
3) Coding quidelines are not respected in Java. Missing empty lines between 
semantically different lines, incorrect { placement (.Net style instead of Java 
style).

Vladimir.

> .NET: Support user-defined AffinityFunction
> -------------------------------------------
>
>                 Key: IGNITE-3328
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3328
>             Project: Ignite
>          Issue Type: New Feature
>          Components: platforms
>    Affects Versions: 1.6
>            Reporter: Pavel Tupitsyn
>            Assignee: Vladimir Ozerov
>            Priority: Critical
>              Labels: .net
>             Fix For: 1.7
>
>
> Allow custom AffinityFunction implementation in .NET
> Make sure it can be set in XML config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to