[ 
https://issues.apache.org/jira/browse/IGNITE-20309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760510#comment-17760510
 ] 

Ignite TC Bot commented on IGNITE-20309:
----------------------------------------

{panel:title=Branch: [pull/10913/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/10913/head] Base: [master] : New Tests 
(6)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Disk Page Compressions 1{color} [[tests 
2|https://ci2.ignite.apache.org/viewLog.html?buildId=7322534]]
* {color:#013220}IgnitePdsCompressionTestSuite: 
IgniteClusterSnapshotHandlerTest.testHandlerExceptionFailSnapshot[encryption=false,
 onlyPrimay=true] - PASSED{color}
* {color:#013220}IgnitePdsCompressionTestSuite: 
IgniteClusterSnapshotHandlerTest.testHandlerExceptionFailSnapshot[encryption=false,
 onlyPrimay=false] - PASSED{color}

{color:#00008b}Snapshots{color} [[tests 
4|https://ci2.ignite.apache.org/viewLog.html?buildId=7322555]]
* {color:#013220}IgniteSnapshotTestSuite: 
IgniteClusterSnapshotHandlerTest.testHandlerExceptionFailSnapshot[encryption=false,
 onlyPrimay=true] - PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite: 
IgniteClusterSnapshotHandlerTest.testHandlerExceptionFailSnapshot[encryption=false,
 onlyPrimay=false] - PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite: 
IgniteClusterSnapshotHandlerTest.testHandlerExceptionFailSnapshot[encryption=true,
 onlyPrimay=true] - PASSED{color}
* {color:#013220}IgniteSnapshotTestSuite: 
IgniteClusterSnapshotHandlerTest.testHandlerExceptionFailSnapshot[encryption=true,
 onlyPrimay=false] - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=7321997&buildTypeId=IgniteTests24Java8_RunAll]

> Snapshot creation returns OK even if check failed
> -------------------------------------------------
>
>                 Key: IGNITE-20309
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20309
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Nikolay Izhikov
>            Assignee: Nikolay Izhikov
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Currently, {{SnapshotPartitionsQuickVerifyHandler#complete}} don't fail 
> snapshot even if {{invoke}} throws.
> Reproducer:
>  
> {noformat}
>     /**
>      * Test ensures that snapshot fail if during check some files are absent.
>      * @see SnapshotPartitionsQuickVerifyHandler
>      */
>     @Test
>     public void testHandlerExceptionFailSnapshot() throws Exception {
>         handlers.add(new SnapshotHandler<Void>() {
>             @Override public SnapshotHandlerType type() {
>                 return SnapshotHandlerType.CREATE;
>             }
>             @Override public Void invoke(SnapshotHandlerContext ctx) {
>                 // Someone remove snapshot files during creation.
>                 // In this case snapshot must fail.
>                 U.delete(ctx.snapshotDirectory());
>                 return null;
>             }
>         });
>         IgniteEx ignite = startGridsWithCache(1, CACHE_KEYS_RANGE, 
> valueBuilder(), dfltCacheCfg);
>         assertThrows(
>             null,
>             () -> snp(ignite).createSnapshot("must_fail", null, false, 
> onlyPrimary).get(getTestTimeout()),
>             IgniteException.class,
>             "Snapshot data doesn't contain required cache group partition"
>         );
>     }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to