Viacheslav Blinov created IGNITE-21697:
------------------------------------------

             Summary: ConnectionManager ignores exceptional return value of 
ExecutorService.submit
                 Key: IGNITE-21697
                 URL: https://issues.apache.org/jira/browse/IGNITE-21697
             Project: Ignite
          Issue Type: Task
            Reporter: Viacheslav Blinov


Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
M M JLM_JSR166_UTILCONCURRENT_MONITORENTER JLM: Synchronization performed on 
java.util.concurrent.atomic.AtomicReferenceArray in 
org.apache.ignite.internal.network.LazyStripedExecutor.executorFor(short)  At 
LazyStripedExecutor.java:[line 88] {noformat}
Instances of java.util.concurrent.atomic classes have their own concurrency 
control mechanisms that are orthogonal to the synchronization provided by the 
Java keyword {{{}synchronized{}}}. For example, synchronizing on an 
{{AtomicBoolean}} will not prevent other threads from modifying the 
{{{}AtomicBoolean{}}}.

Such code may be correct, but should be carefully reviewed and documented, and 
may confuse people who have to maintain the code at a later date.

Investigate whenever this is a false-positive and we should suppress it, or we 
should make a proper fix.
At the result of investigation corresponding TODO should be removed in 
spotbugs-excludes.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to