[ https://issues.apache.org/jira/browse/IGNITE-21723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksandr updated IGNITE-21723: ------------------------------- Description: I've played around with our CLI profiles and configuration here is some thoughts: - Why do "defaults" and "secrets" files do not have ".ini" file type? the lack of this makes it impossible for editors to understand the file type. - Why "defaults" file stores all profiles? For example, vanilla CLI application creates "defaults" file and it is fine. There is a "default" profile configurations under "[default]" ini section and this is fine. But when I create new profile through CLI, say, "apakh" and change a couple of properties, I see "[apakh]" section in the "defaults" file and this is strange. I do not want to see all profile's configurations in the same file named "defaults". - Why do I see empty values for the configurations from "secrets" file when execute "cli config show"? - Why the ordering in properties is mixed when I call "cli config show"? There is a mess and it is hard to find a property I am interested in. - Why do we put "ignite." prefix to every property? Is there any reason for adding a prefix "ignite" to the CLI for "Ignite"? - Why "secrets" file has -rwx------ rights? (+x). - And the most interesting one. Why do we use ".ini" format for configuring our CLI application that is supposed to be use in *unix systems (mostly). I propose the following changes. Introduce a directory-oriented profile management. -- ignitecli/ ---- profiles/ ------ default/ -------- config.ini -------- secrets.ini ------ apakh/ -------- config.ini -------- secrets.ini Add ".ini" filetype Remove "ignite" prefix from all configuration keys. Do not mix the "cli config show" output. was: I've played around with our CLI profiles and configuration here is some thoughts: - Why do "defaults" and "secrets" files do not have ".ini" file type? the lack of this makes it impossible for editors to understand the file type. - Why "defaults" file stores all profiles? For example, vanilla CLI application creates "defaults" file and it is fine. There is a "default" profile configurations under "[default]" ini section and this is fine. But when I create new profile through CLI, say, "apakh" and change a couple of properties, I see "[apakh]" section in the "defaults" file and this is strange. I do not want to see all profile's configurations in the same file named "defaults". - Why do I see empty values for the configurations from "secrets" file when execute "cli config show"? - Why the ordering in properties is mixed when I call "cli config show"? There is a mess and it is hard to find a property I am interested in. - Why do we put "ignite." prefix to every property? Is there any reason for adding a prefix "ignite" to the CLI for "Ignite"? - And the most interesting one. Why do we use ".ini" format for configuring our CLI application that is supposed to be use in *unix systems (mostly). I propose the following changes. Introduce a directory-oriented profile management. -- ignitecli/ ---- profiles/ ------ default/ -------- config.ini -------- secrets.ini ------ apakh/ -------- config.ini -------- secrets.ini Add ".ini" filetype Do not mix the "cli config show" output. > CLI profiles improvements > ------------------------- > > Key: IGNITE-21723 > URL: https://issues.apache.org/jira/browse/IGNITE-21723 > Project: Ignite > Issue Type: Improvement > Components: cli > Reporter: Aleksandr > Priority: Major > Labels: ignite-3 > > I've played around with our CLI profiles and configuration here is some > thoughts: > - Why do "defaults" and "secrets" files do not have ".ini" file type? the > lack of this makes it impossible for editors to understand the file type. > - Why "defaults" file stores all profiles? For example, vanilla CLI > application creates "defaults" file and it is fine. There is a "default" > profile configurations under "[default]" ini section and this is fine. But > when I create new profile through CLI, say, "apakh" and change a couple of > properties, I see "[apakh]" section in the "defaults" file and this is > strange. I do not want to see all profile's configurations in the same file > named "defaults". > - Why do I see empty values for the configurations from "secrets" file when > execute "cli config show"? > - Why the ordering in properties is mixed when I call "cli config show"? > There is a mess and it is hard to find a property I am interested in. > - Why do we put "ignite." prefix to every property? Is there any reason for > adding a prefix "ignite" to the CLI for "Ignite"? > - Why "secrets" file has -rwx------ rights? (+x). > - And the most interesting one. Why do we use ".ini" format for configuring > our CLI application that is supposed to be use in *unix systems (mostly). > I propose the following changes. > Introduce a directory-oriented profile management. > -- ignitecli/ > ---- profiles/ > ------ default/ > -------- config.ini > -------- secrets.ini > ------ apakh/ > -------- config.ini > -------- secrets.ini > Add ".ini" filetype > Remove "ignite" prefix from all configuration keys. > Do not mix the "cli config show" output. > -- This message was sent by Atlassian Jira (v8.20.10#820010)