[
https://issues.apache.org/jira/browse/IGNITE-22386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851039#comment-17851039
]
Roman Puchkovskiy commented on IGNITE-22386:
--------------------------------------------
The patch looks good to me
> Many usages of wrong revision serialization in metastorage commands
> -------------------------------------------------------------------
>
> Key: IGNITE-22386
> URL: https://issues.apache.org/jira/browse/IGNITE-22386
> Project: Ignite
> Issue Type: Bug
> Reporter: Ivan Bessonov
> Assignee: Ivan Bessonov
> Priority: Major
> Labels: ignite-3
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> {code:java}
> byte[] revisionBytes = ByteUtils.longToBytes(revision);
> Iif iif = iif(
> notExists(partChangeTriggerKey).or(value(partChangeTriggerKey).lt(revisionBytes)),
> {code}
> Code above has a bug - "longToBytes" is not a suitable serialization format
> for preserving natural comparison order used in "lt". We must fix it, because
> it leads to occasional false-positive and false-negative condition evaluation
> It also leads to flaky tests, obviously
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
