[
https://issues.apache.org/jira/browse/IGNITE-22918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Shishkov updated IGNITE-22918:
-----------------------------------
Description:
{{GridDhtLockResponse#nearEvicted()}} method does not have any usage, i.e.
{{GridDhtLockResponse#nearEvicted}} field update has no further effect [1, 2].
We have to figure out whether this is redundant code or whether we have l*_ost
of some useful functionality_*.
#
https://github.com/apache/ignite/blob/209af6ab9a7103612d7564f2372c44653a65c407/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTransactionalCacheAdapter.java#L477
#
https://github.com/apache/ignite/blob/209af6ab9a7103612d7564f2372c44653a65c407/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTransactionalCacheAdapter.java#L488
was:
{{GridDhtLockRequest#addNearKey(KeyCacheObject)}} does not have any usage, i.e.
{{GridDhtLockRequest#nearKeys}} is not updated at all.
So, {{nearKeys}} always returns empty collection and, moreover, some code
becomes useless, eg. {{GridNearTransactionalCache#startRemoteTx(UUID,
GridDhtLockRequest)}} [1], etc.
We have to figure out whether this is redundant code or whether we have lost of
some useful functionality.
#
https://github.com/apache/ignite/blob/209af6ab9a7103612d7564f2372c44653a65c407/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java#L285
> Remove GridDhtLockRequest#nearEvicted
> -------------------------------------
>
> Key: IGNITE-22918
> URL: https://issues.apache.org/jira/browse/IGNITE-22918
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Priority: Minor
> Labels: ise
>
> {{GridDhtLockResponse#nearEvicted()}} method does not have any usage, i.e.
> {{GridDhtLockResponse#nearEvicted}} field update has no further effect [1, 2].
> We have to figure out whether this is redundant code or whether we have
> l*_ost of some useful functionality_*.
> #
> https://github.com/apache/ignite/blob/209af6ab9a7103612d7564f2372c44653a65c407/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTransactionalCacheAdapter.java#L477
> #
> https://github.com/apache/ignite/blob/209af6ab9a7103612d7564f2372c44653a65c407/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtTransactionalCacheAdapter.java#L488
--
This message was sent by Atlassian Jira
(v8.20.10#820010)