[
https://issues.apache.org/jira/browse/IGNITE-22919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Shishkov updated IGNITE-22919:
-----------------------------------
Description:
Getter {{GridNearLockRequest#filter()}} does not have any usage, i.e. calls to
setter becomes useless: [1, 2]
We have to figure out whether this is redundant code or whether we have *_lost
some useful functionality_*.
#
https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java#L1223
#
https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java#L1218
was:
{{GridDhtLockRequest#addNearKey(KeyCacheObject)}} does not have any usage, i.e.
{{GridDhtLockRequest#nearKeys}} is not updated at all.
So, {{nearKeys}} always returns empty collection and, moreover, some code
becomes useless, eg. {{GridNearTransactionalCache#startRemoteTx(UUID,
GridDhtLockRequest)}} [1], etc.
We have to figure out whether this is redundant code or whether we have *_lost
some useful functionality_*.
#
https://github.com/apache/ignite/blob/209af6ab9a7103612d7564f2372c44653a65c407/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java#L285
> Remove GridNearLockRequest#filter
> ---------------------------------
>
> Key: IGNITE-22919
> URL: https://issues.apache.org/jira/browse/IGNITE-22919
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Priority: Minor
> Labels: ise
>
> Getter {{GridNearLockRequest#filter()}} does not have any usage, i.e. calls
> to setter becomes useless: [1, 2]
> We have to figure out whether this is redundant code or whether we have
> *_lost some useful functionality_*.
> #
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java#L1223
> #
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java#L1218
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
