[ 
https://issues.apache.org/jira/browse/IGNITE-23198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Iurii Gerzhedovich updated IGNITE-23198:
----------------------------------------
    Description: 
We have a few muted tests under IGNITE-19858, however, the issue has already 
been fixed.

The reason of the issue is the incorrect work of saturated casts for negative 
double and real types.
For some reason, the parser returns RexCall with the minus operation and 
literal for such approximate negative literals.

Here are different approaches to fixing the issue:
1. Figure out why the parser has such behavior for literals like 
'-340282346638528860000000000000000000000.000000000000000000000000000000000000000000001401298464324817::REAL'
 .
2. Fix org.apache.ignite.internal.sql.engine.util.RexUtils#toSaturatedValue to 
handle such wrapped literals.

3. Something else.

 

So, need to find mention of IGNITE-19858 ticket to start fixing it.

 

  was:
We have a few muted tests under IGNITE-19858, however, the issue has already 
been fixed.

However, the issue is the incorrect work of saturated casts for negative 
decimal and real types.
For some reason, the parser returns RexCall with the minus operation and 
literal for such approximate negative literals.


Here are different approaches to fixing the issue:
1. Figure out why the parser has such behavior for literals like 
'-340282346638528860000000000000000000000.000000000000000000000000000000000000000000001401298464324817::REAL'
 .
2. Fix org.apache.ignite.internal.sql.engine.util.RexUtils#toSaturatedValue to 
handle such wrapped literals.

3. Something else.

 

So, need to find mention of IGNITE-19858 ticket to start fixing it.

 


> Sql. Saturated casts don't work for negative approximated types
> ---------------------------------------------------------------
>
>                 Key: IGNITE-23198
>                 URL: https://issues.apache.org/jira/browse/IGNITE-23198
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Iurii Gerzhedovich
>            Priority: Major
>              Labels: ignite-3
>
> We have a few muted tests under IGNITE-19858, however, the issue has already 
> been fixed.
> The reason of the issue is the incorrect work of saturated casts for negative 
> double and real types.
> For some reason, the parser returns RexCall with the minus operation and 
> literal for such approximate negative literals.
> Here are different approaches to fixing the issue:
> 1. Figure out why the parser has such behavior for literals like 
> '-340282346638528860000000000000000000000.000000000000000000000000000000000000000000001401298464324817::REAL'
>  .
> 2. Fix org.apache.ignite.internal.sql.engine.util.RexUtils#toSaturatedValue 
> to handle such wrapped literals.
> 3. Something else.
>  
> So, need to find mention of IGNITE-19858 ticket to start fixing it.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to