[ 
https://issues.apache.org/jira/browse/IGNITE-22919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882671#comment-17882671
 ] 

Ilya Shishkov edited comment on IGNITE-22919 at 9/18/24 11:06 AM:
------------------------------------------------------------------

In addition to described above, it seems that there are some places, where 
filter is alway empty or null, eg. {{CU.empty0}} is passed as argument of 
method or constructor.

Such empty filters were added in IGNITE-683 (since AI 1.1.3):
https://github.com/apache/ignite/commit/923961dc108b91ef5543e33c615f9098e8630cbf


was (Author: shishkovilja):
In addition to described above, it seems that there are some places, where 
filter is alway empty or null, eg. {{CU.empty0}} is passed as argument of 
method or constructor.

Such empty filters were added in IGNITE-683 (since AI 1.1.3).

> Remove redundant CacheEntryPredicate filters
> --------------------------------------------
>
>                 Key: IGNITE-22919
>                 URL: https://issues.apache.org/jira/browse/IGNITE-22919
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Ilya Shishkov
>            Assignee: Ilya Shishkov
>            Priority: Minor
>              Labels: ise
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Getter {{GridNearLockRequest#filter()}} does not have any usage, i.e. calls 
> of setter become useless too: [1, 2]
> We have to figure out whether this is redundant code or whether we have 
> *_lost some useful functionality_*.
> # 
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/colocated/GridDhtColocatedLockFuture.java#L1224
> # 
> https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearLockFuture.java#L1218



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to