[
https://issues.apache.org/jira/browse/IGNITE-23368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Steshin updated IGNITE-23368:
--------------------------------------
Description:
* We should get rid of `instance of LazyServiceConfiguration` usages. Or get
rid of several `if( instance of LazyServiceConfiguration)`. It is always the
extended configuration with normal deployment, with the public API. No need to
check/cast.
* The {{ServiceConfiguration}} class should not participate in serialization.
Or the extended configuration should be `Externalizable` for example.
`LazyServiceConfiguration` should not have the duplicates of the base
`ServiceConfiguration`s `IgnitePredicate<ClusterNode> nodeFilter`,
`ServiceCallInterceptor[] interceptors` and probably `Service svc`.
* Revisit #toString method. It might give more info like `serviceName`,
`nodeFilterClass`, `totalCnt`, `perNodeCnt`, etc.
* Is the name "lazy" appropriate for this class? Maybe like
`BinaryServiceConfiguration` or `SerializationServiceConfiguration`.
was:
* We should get rid of `instance of LazyServiceConfiguration` usages.
* The {{ServiceConfiguration}} class should not participate in serialization.
* Revisit #toString method.
* Is the name "lazy" appropriate for this class?
> Refactor processing of lazy service configuration
> -------------------------------------------------
>
> Key: IGNITE-23368
> URL: https://issues.apache.org/jira/browse/IGNITE-23368
> Project: Ignite
> Issue Type: Improvement
> Reporter: Nikita Amelchev
> Priority: Minor
>
> * We should get rid of `instance of LazyServiceConfiguration` usages. Or get
> rid of several `if( instance of LazyServiceConfiguration)`. It is always the
> extended configuration with normal deployment, with the public API. No need
> to check/cast.
> * The {{ServiceConfiguration}} class should not participate in serialization.
> Or the extended configuration should be `Externalizable` for example.
> `LazyServiceConfiguration` should not have the duplicates of the base
> `ServiceConfiguration`s `IgnitePredicate<ClusterNode> nodeFilter`,
> `ServiceCallInterceptor[] interceptors` and probably `Service svc`.
> * Revisit #toString method. It might give more info like `serviceName`,
> `nodeFilterClass`, `totalCnt`, `perNodeCnt`, etc.
> * Is the name "lazy" appropriate for this class? Maybe like
> `BinaryServiceConfiguration` or `SerializationServiceConfiguration`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
