[
https://issues.apache.org/jira/browse/IGNITE-26221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015372#comment-18015372
]
Tiago Marques Godinho commented on IGNITE-26221:
------------------------------------------------
The test failures hint at a deadlock because timings are very stable for all
successful tests (around 1s) but they hit the timeout for unsuccessful ones.
However, I did not manage to discover a deadlock in the code.
I decided to increase the polling rate for `IgniteTestUtils.waitForCondition`
to cut the CPU some slack. Nonetheless, the failure profile does not seem to
indicate a timing issue at all.
I'll also bump the limit to 6s.
There's another possibility that may explain the scarce nature of the failures.
Currently, the metrics are updated from a routine on the ForkJoinPool. This
pool might be flooded with tasks from other tests or the JUnit framework itself.
We could set a separate executor for the client to alleviate this issue.
{code:java}
.asyncContinuationExecutor(Executors.newSingleThreadExecutor())
{code}
I'll apply these changes and keep checking out for failures in the test.
> org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout is
> flaky
> -------------------------------------------------------------------------------
>
> Key: IGNITE-26221
> URL: https://issues.apache.org/jira/browse/IGNITE-26221
> Project: Ignite
> Issue Type: Bug
> Components: thin clients ai3
> Reporter: Pavel Tupitsyn
> Assignee: Tiago Marques Godinho
> Priority: Major
> Labels: ignite-3
> Fix For: 3.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Still flaky after IGNITE-25922
> https://ci.ignite.apache.org/project.html?projectId=ApacheIgnite3xGradle_Test_RunUnitTests_virtual&testNameId=-1906592650553487805&tab=testDetails&branch_ApacheIgnite3xGradle_Test_RunUnitTests_virtual=__all_branches__
> {code}
> org.opentest4j.AssertionFailedError: handshakesFailedTimeout: 0 ==> expected:
> <true> but was: <false>
> at
> app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> at
> app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
> at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:42)
> at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:191)
> at
> app//org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout(ClientMetricsTest.java:163)
> at [email protected]/java.lang.reflect.Method.invoke(Method.java:568)
> at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
> at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1511)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
