[
https://issues.apache.org/jira/browse/IGNITE-27098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrey Mashenkov updated IGNITE-27098:
--------------------------------------
Description:
Public API has two exception classes representing the same error.
* `org.apache.ignite.lang.MarshallerException`
* `org.apache.ignite.marshalling.MarshallingException`
Let's deprecate the second one and make it child of the first one.
Unfortunatelly there are bunch of issues
* `ByteArrayMarshaller.unmarshal` throws MarshallingException however there
should be `org.apache.ignite.marshalling.UnmarshallingException`, according to
the logic of the whole PR where all of this stuff was added.
* `org.apache.ignite.marshalling.UnsupportedObjectTypeMarshallingException` is
not a part of marshaller exception hierarchy. Actually, none of them has
meaningful parent.
* `org.apache.ignite.marshalling.Marshaller` methods declare throwing a
`UnsupportedObjectTypeMarshallingException`, however `MarshallerException` can
be thrown as well.
was:
Public API has two exception classes representing the same error.
* `org.apache.ignite.lang.MarshallerException`
* `org.apache.ignite.marshalling.MarshallingException`
Let's deprecate the second one and make it child of the first one.
Unfortunatelly there are bunch of issues that should never pass the PR review
(I believe).
* `ByteArrayMarshaller.unmarshal` throws MarshallingException however there
should be `org.apache.ignite.marshalling.UnmarshallingException`, according to
the logic of the whole PR where all of this stuff was added.
* `org.apache.ignite.marshalling.UnsupportedObjectTypeMarshallingException` is
not a part of marshaller exception hierarchy. Actually, none of them has
meaningful parent.
* `org.apache.ignite.marshalling.Marshaller` methods declare throwing a
`UnsupportedObjectTypeMarshallingException`, however `MarshallerException` can
be thrown as well.
> Duplicate Marshaller exception class.
> -------------------------------------
>
> Key: IGNITE-27098
> URL: https://issues.apache.org/jira/browse/IGNITE-27098
> Project: Ignite
> Issue Type: Improvement
> Components: compute ai3
> Reporter: Andrey Mashenkov
> Priority: Major
> Labels: ignite-3, tech-debt
> Fix For: 3.2
>
>
> Public API has two exception classes representing the same error.
> * `org.apache.ignite.lang.MarshallerException`
> * `org.apache.ignite.marshalling.MarshallingException`
> Let's deprecate the second one and make it child of the first one.
>
> Unfortunatelly there are bunch of issues
> * `ByteArrayMarshaller.unmarshal` throws MarshallingException however there
> should be `org.apache.ignite.marshalling.UnmarshallingException`, according
> to the logic of the whole PR where all of this stuff was added.
> * `org.apache.ignite.marshalling.UnsupportedObjectTypeMarshallingException`
> is not a part of marshaller exception hierarchy. Actually, none of them has
> meaningful parent.
> * `org.apache.ignite.marshalling.Marshaller` methods declare throwing a
> `UnsupportedObjectTypeMarshallingException`, however `MarshallerException`
> can be thrown as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
