[ 
https://issues.apache.org/jira/browse/IGNITE-27098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039464#comment-18039464
 ] 

Aleksandr commented on IGNITE-27098:
------------------------------------

Im ok with getting rid of org.apache.ignite.marshalling.MarshallingException if 
we can do so (probably we're going to "break" the public API...). 

If we can not remove this exception, let's inherit it from the `lang` one.

> Duplicate Marshaller exception class.
> -------------------------------------
>
>                 Key: IGNITE-27098
>                 URL: https://issues.apache.org/jira/browse/IGNITE-27098
>             Project: Ignite
>          Issue Type: Improvement
>          Components: compute ai3
>            Reporter: Andrey Mashenkov
>            Priority: Major
>              Labels: ignite-3, tech-debt
>             Fix For: 3.2
>
>
> Public API has two exception classes representing the same error.
>  * `org.apache.ignite.lang.MarshallerException`
>  * `org.apache.ignite.marshalling.MarshallingException`
> Let's deprecate the second one and make it child of the first one.
>  
> Unfortunatelly there are bunch of issues 
>  * `ByteArrayMarshaller.unmarshal` throws MarshallingException however there 
> should be `org.apache.ignite.marshalling.UnmarshallingException`, according 
> to the logic of the whole PR where all of this stuff was added.
>  * `org.apache.ignite.marshalling.UnsupportedObjectTypeMarshallingException` 
> is not a part of marshaller exception hierarchy. Actually, none of them has 
> meaningful parent.
>  * `org.apache.ignite.marshalling.Marshaller` methods declare throwing a 
> `UnsupportedObjectTypeMarshallingException`, however `MarshallerException` 
> can be thrown as well.
>  * `org.apache.ignite.marshalling.TupleMarshaller` interface is not used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to