[
https://issues.apache.org/jira/browse/IGNITE-27467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Lapin updated IGNITE-27467:
-------------------------------------
Description:
Aforementioned test was muted with
https://issues.apache.org/jira/browse/IGNITE-24345, however it's likely not
related. In given test we verify that futures in
finishHandleChangeStableAssignmentEventFutures map were completed properly,
however in ItRebalanceDistributedTest such futures are never competed. I
believe that the test class misses
{code:java}
partitionReplicaLifecycleManager = new PartitionReplicaLifecycleManager(
...
) {
@Override
protected CompletableFuture<Void>
handleChangeStableAssignmentEvent(WatchEvent evt) {
ZonePartitionId zonePartitionId = getZonePartitionId(evt);
CompletableFuture<Void> result;
CompletableFuture<Void> finishHandleChangeStableAssignmentEventFuture =
finishHandleChangeStableAssignmentEventFutures.get(zonePartitionId);
try {
result = super.handleChangeStableAssignmentEvent(evt);
// In some tests finishHandleChangeStableAssignmentEventFutures is
not populated.
if (zonePartitionId != null &&
finishHandleChangeStableAssignmentEventFuture != null) {
finishHandleChangeStableAssignmentEventFuture.complete(null);
}
} catch (Throwable t) {
// In some tests finishHandleChangeStableAssignmentEventFutures is
not populated.
if (zonePartitionId != null &&
finishHandleChangeStableAssignmentEventFuture != null) {
finishHandleChangeStableAssignmentEventFuture.completeExceptionally(t);
}
throw t;
}
return result;
}
}; {code}
lIt's possible to use 9663f837880bbb6664c030e6b60a220509897196 revision as a
reference implementation of how to handle
finishHandleChangeStableAssignmentEventFutures.
was:Aforementioned test was muted with
https://issues.apache.org/jira/browse/IGNITE-24345, however it's likely not
related. In given test we verify that futures in
finishHandleChangeStableAssignmentEventFutures map were completed properly,
however in
> ItRebalanceDistributedTest#testDestroyPartitionStoragesOnRestartEvictedNode
> fails
> ---------------------------------------------------------------------------------
>
> Key: IGNITE-27467
> URL: https://issues.apache.org/jira/browse/IGNITE-27467
> Project: Ignite
> Issue Type: Bug
> Reporter: Alexander Lapin
> Priority: Major
> Labels: ignite-3
>
> Aforementioned test was muted with
> https://issues.apache.org/jira/browse/IGNITE-24345, however it's likely not
> related. In given test we verify that futures in
> finishHandleChangeStableAssignmentEventFutures map were completed properly,
> however in ItRebalanceDistributedTest such futures are never competed. I
> believe that the test class misses
>
> {code:java}
> partitionReplicaLifecycleManager = new PartitionReplicaLifecycleManager(
> ...
> ) {
> @Override
> protected CompletableFuture<Void>
> handleChangeStableAssignmentEvent(WatchEvent evt) {
> ZonePartitionId zonePartitionId = getZonePartitionId(evt);
> CompletableFuture<Void> result;
> CompletableFuture<Void> finishHandleChangeStableAssignmentEventFuture
> =
>
> finishHandleChangeStableAssignmentEventFutures.get(zonePartitionId);
> try {
> result = super.handleChangeStableAssignmentEvent(evt);
> // In some tests finishHandleChangeStableAssignmentEventFutures
> is not populated.
> if (zonePartitionId != null &&
> finishHandleChangeStableAssignmentEventFuture != null) {
> finishHandleChangeStableAssignmentEventFuture.complete(null);
> }
> } catch (Throwable t) {
> // In some tests finishHandleChangeStableAssignmentEventFutures
> is not populated.
> if (zonePartitionId != null &&
> finishHandleChangeStableAssignmentEventFuture != null) {
>
> finishHandleChangeStableAssignmentEventFuture.completeExceptionally(t);
> }
> throw t;
> }
> return result;
> }
> }; {code}
> lIt's possible to use 9663f837880bbb6664c030e6b60a220509897196 revision as a
> reference implementation of how to handle
> finishHandleChangeStableAssignmentEventFutures.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
