[
https://issues.apache.org/jira/browse/IGNITE-27627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Shishkov updated IGNITE-27627:
-----------------------------------
Description:
To transfer custom message, we need wrap {{DiscoveryCustomMessage}} into
{{TcpDiscoveryCustomEventMessage}}.
Moreover, {{TcpDiscoveryCustomEventMessage#msgByte}} for marshalling /
unmarshalling. They are also should be removed (it could be possible, when all
custom messages will migrate to the new framework).
We can at least, remove {{prepareMarshal}} / {{finishUnmarshall}} from
{{TcpDiscoveryCustomEventMessage}} or remove {{TcpDiscoveryCustomEventMessage}}
at all and serialize {{DiscoveryCustomMessage}} directly via
{{TcpDiscoveryIoSession}}.
was:
To transfer custom message, we need wrap {{DiscoverySpiCustomMessage}} into
{{TcpDiscoveryCustomEventMessage}}, and in turn {{DiscoveryCustomMessage}} into
{{DiscoverySpiCustomMessage}}.
This logic seems to be redundant and should be refactored.
Moreover, {{TcpDiscoveryCustomEventMessage#msgByte}} for marshalling /
unmarshalling. They are also should be removed (it could be possible, when all
custom messages will migrate to the new framework).
> Refactor custom message serialization
> -------------------------------------
>
> Key: IGNITE-27627
> URL: https://issues.apache.org/jira/browse/IGNITE-27627
> Project: Ignite
> Issue Type: Task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Major
> Labels: IEP-132, ise
>
> To transfer custom message, we need wrap {{DiscoveryCustomMessage}} into
> {{TcpDiscoveryCustomEventMessage}}.
> Moreover, {{TcpDiscoveryCustomEventMessage#msgByte}} for marshalling /
> unmarshalling. They are also should be removed (it could be possible, when
> all custom messages will migrate to the new framework).
> We can at least, remove {{prepareMarshal}} / {{finishUnmarshall}} from
> {{TcpDiscoveryCustomEventMessage}} or remove
> {{TcpDiscoveryCustomEventMessage}} at all and serialize
> {{DiscoveryCustomMessage}} directly via {{TcpDiscoveryIoSession}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
