[
https://issues.apache.org/jira/browse/IGNITE-25974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072219#comment-18072219
]
Pavel Tupitsyn commented on IGNITE-25974:
-----------------------------------------
https://github.com/apache/ignite-3/commit/a3fb5800000b3a6922be9929a036570a640f9392
> C++ tests do not catch unsynced changes to ErrorGroups.java
> -----------------------------------------------------------
>
> Key: IGNITE-25974
> URL: https://issues.apache.org/jira/browse/IGNITE-25974
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 3.1
> Reporter: Aditya Mukhopadhyay
> Assignee: Dmitrii Zabotlin
> Priority: Major
> Labels: ignite-3
> Fix For: 3.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When an error code is added or modified in ErrorCodes.java, it used to be the
> case that upon building the project, the corresponding changes would be
> auto-generated for C++ client code. If this step is omitted, TC C++ tests
> should fail by design.
> However, for the following PR:
> [https://github.com/apache/ignite-3/pull/6262]
> As of the commit:
> [2a38162baf24a8a042ae15170835a292a12fac88|https://github.com/apache/ignite-3/pull/6262/commits/2a38162baf24a8a042ae15170835a292a12fac88],
> only ErrorGroups.java (and related C# files) have been updated, but no
> corresponding changes to the C++ error groups are present. Despite this
> mismatch, the TC tests pass completely, as evidenced at
> [https://ci.ignite.apache.org/buildConfiguration/ApacheIgnite3xGradle_Test_RunAllTests/9319034.]
> This is incorrect behaviour and needs to be fixed.
> *Definition of done:*
> When you change error codes in ErrorGroups.java and then build the project,
> new error codes for C++ will be auto-generated, which you then will have to
> commit. If you won't do this, TC C++ tests should fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
