[
https://issues.apache.org/jira/browse/IGNITE-27627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075919#comment-18075919
]
Ignite TC Bot commented on IGNITE-27627:
----------------------------------------
{panel:title=Branch: [pull/13023/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13023/head] Base: [master] : New Tests
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}SPI (Discovery){color} [[tests
1|https://ci2.ignite.apache.org/viewLog.html?buildId=9027646]]
* {color:#013220}IgniteSpiDiscoverySelfTestSuite:
DiscoveryUnmarshalVulnerabilityTest.testExploitDirectly - PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9027689&buildTypeId=IgniteTests24Java8_RunAll]
> Remove support of java serialization for tcp discovery messages
> ---------------------------------------------------------------
>
> Key: IGNITE-27627
> URL: https://issues.apache.org/jira/browse/IGNITE-27627
> Project: Ignite
> Issue Type: Task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Major
> Labels: IEP-132, ise
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> To transfer custom message, we need wrap {{DiscoveryCustomMessage}} into
> {{TcpDiscoveryCustomEventMessage}}.
> Moreover, {{TcpDiscoveryCustomEventMessage#msgByte}} and {{#serMsg}} are
> used for marshalling / unmarshalling. They also should be removed (it could
> be possible, when all custom messages will migrate to the new framework).
> We can at least, remove {{prepareMarshal}} / {{finishUnmarshall}} from
> {{TcpDiscoveryCustomEventMessage}} or remove
> {{TcpDiscoveryCustomEventMessage}} at all and serialize
> {{DiscoveryCustomMessage}} directly via {{TcpDiscoveryIoSession}}.
> Also:
> # {{SecurityAwareCustomMessageWrapper}} should be refactored.
> # Support of {{Serializable}} messages can be removed from
> {{TcpDiscoveryIoSession}}, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
