[
https://issues.apache.org/jira/browse/IGNITE-28636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18079563#comment-18079563
]
Ignite TC Bot commented on IGNITE-28636:
----------------------------------------
{panel:title=Branch: [pull/13110/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13110/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9055189&buildTypeId=IgniteTests24Java8_RunAll]
> Do not check message type by raw numbers.
> -----------------------------------------
>
> Key: IGNITE-28636
> URL: https://issues.apache.org/jira/browse/IGNITE-28636
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladimir Steshin
> Assignee: Vladimir Steshin
> Priority: Major
> Labels: IEP-132, ise
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In {_}GridCacheIoManager{_}:
>
> {code:java}
> switch (msg.directType()) {
> case 10022:
> case 10016:
> case 10303:
> case 10305:
> case 10300:
> ...{code}
>
> In {_}IgniteTxManager{_}:
> {code:java}
> switch (msg.directType()) {
> case 10003:
> case 10004:
> ...{code}
> We should not use raw numbers to detect message type. At least constants
> should be involved. Or {_}instanceof{_}. Or we might ask the factory some how.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
