[ https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484010#comment-15484010 ]
Anton Vinogradov edited comment on IGNITE-3303 at 9/12/16 12:53 PM: -------------------------------------------------------------------- Saikat, I've started from tests run, one failed, so I did not checked whole code. Comments: 1) Code should be compilable under java 7. 2) testFlinkIgniteSourceWithLargeBatch fails with error (log attached). 3) igniteCfgFile still static 4) evtBuf static too, and I still see no reasons to have it static. Could you please explain why tests can't be written while it's non static? 5) I can't find Singelton pattern usage, still see creation via {noformat}final IgniteSource igniteSrc = new IgniteSource(TEST_CACHE, GRID_CONF_FILE);{noformat} I checked creation and start of new/same instance and it is not cause exceptions. was (Author: avinogradov): Saikat, I've started from tests run, one failed, so I did not checked whole code. Comments: 1) Code should be compilable under java 7. 2) testFlinkIgniteSourceWithLargeBatch fails with error (log attached). 3) igniteCfgFile still static 4) evtBuf static too, and I still see no reasons to have it static. Could you please explain why tests can't be writen while it's non static? 5) I can't find Singelton patter usage, still see creation via {noformat}final IgniteSource igniteSrc = new IgniteSource(TEST_CACHE, GRID_CONF_FILE);{noformat} I checked creation and start of new/same instance and it is not cause exceptions. > Apache Flink Integration - Flink source to run a continuous query against one > or multiple caches > ------------------------------------------------------------------------------------------------ > > Key: IGNITE-3303 > URL: https://issues.apache.org/jira/browse/IGNITE-3303 > Project: Ignite > Issue Type: New Feature > Components: streaming > Reporter: Saikat Maitra > Assignee: Saikat Maitra > Attachments: testFlinkIgniteSourceWithLargeBatch.log > > > Apache Flink integration > +++ *Ignite as a bidirectional Connector* +++ > As a Flink source => run a continuous query against one or multiple > caches [4]. > Related discussion : > http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Flink-lt-gt-Apache-Ignite-integration-td8163.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)