Anton Vinogradov created IGNITE-28822:
-----------------------------------------
Summary: Protected Classes CI check: reduce cognitive complexity
of the detection script
Key: IGNITE-28822
URL: https://issues.apache.org/jira/browse/IGNITE-28822
Project: Ignite
Issue Type: Task
Reporter: Anton Vinogradov
Assignee: Anton Vinogradov
The detection logic in the "Rolling Upgrade check" step of
.github/workflows/check-protected-classes.yml duplicates two near-identical
loops (added/deleted files vs modified files), differing only in the diff
filter and the grepped revision.
Collapse them into a single loop driven by `git diff --name-status`, selecting
the revision to inspect per file status (A -> head, D/M -> base). This roughly
halves the cyclomatic/cognitive complexity and removes the duplicated loop body.
As a side effect the content-based grep removes a false positive: the previous
diff-based grep matched the file *path* "org/apache/ignite/internal/Order*.java"
in diff headers (the regex dots match slashes), flagging add/delete of the
annotation's own definition file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
