[
https://issues.apache.org/jira/browse/IGNITE-29225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner updated IGNITE-29225:
-----------------------------------
Description:
GridOffHeapProcessor has had no callers since Ignite 2.0, when the page-memory
architecture replaced the old off-heap storage. It was the only production user
of the legacy off-heap map implementations in
org.apache.ignite.internal.util.offheap (module ignite-core). Those maps are
now referenced only by their own tests. Removing the maps also leaves part of
GridUnsafeMemory (module ignite-unsafe) without callers.
Classes to remove (ignite-core):
- org.apache.ignite.internal.processors.offheap.GridOffHeapProcessor
- org.apache.ignite.internal.util.offheap.GridOffHeapEvictListener
- org.apache.ignite.internal.util.offheap.GridOffHeapMap
- org.apache.ignite.internal.util.offheap.GridOffHeapMapFactory
- org.apache.ignite.internal.util.offheap.GridOffHeapPartitionedMap
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLru
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLruPoller
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeMap
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafePartitionedMap
Classes to remove (ignite-unsafe):
- org.apache.ignite.internal.util.offheap.GridOffHeapEvent
- org.apache.ignite.internal.util.offheap.GridOffHeapEventListener
Tests to remove:
- GridByteArrayWrapper
- GridOffHeapMapAbstractSelfTest
- GridOffHeapMapPerformanceAbstractTest
- GridOffHeapPartitionedMapAbstractSelfTest
- GridOffHeapPartitionedMapPerformanceAbstractTest
- GridUnsafeMapSelfTest
- GridUnsafeMapPerformanceTest
- GridUnsafePartitionedMapSelfTest
- GridUnsafePartitionedMapPerformanceTest
- GridUnsafeStripedLruSefTest
Unused members to remove from GridUnsafeMemory:
- event listener support: the lsnr field, listen() and the onEvent() calls in
allocate0()/release0()
- allocate(long, boolean)
- allocateSystem(), releaseSystem(), systemAllocatedSize() and the sysAllocated
counter
- putOffHeap(), removeOffHeap(), get(long)
- unlimited(), freeSize()
- the FREE constant
Also remove the matching entries from IgniteUtilSelfTestSuite,
IgnitePerformanceTestSuite and META-INF/classnames.properties.
GridUnsafeMemory itself stays because it is still used by the Lucene full-text
index in ignite-indexing. GridOffHeapOutOfMemoryException stays because
PageMemoryNoStoreImpl and PagePool use it. GridUnsafeMemorySelfTest stays
unchanged.
was:
GridOffHeapProcessor has had no callers since Ignite 2.0, when the page-memory
architecture replaced the old off-heap storage. It was the only production user
of the legacy off-heap map implementations in
org.apache.ignite.internal.util.offheap (module ignite-core). Those maps are
now referenced only by their own tests.
Classes to remove:
- org.apache.ignite.internal.processors.offheap.GridOffHeapProcessor
- org.apache.ignite.internal.util.offheap.GridOffHeapEvictListener
- org.apache.ignite.internal.util.offheap.GridOffHeapMap
- org.apache.ignite.internal.util.offheap.GridOffHeapMapFactory
- org.apache.ignite.internal.util.offheap.GridOffHeapPartitionedMap
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLru
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLruPoller
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeMap
- org.apache.ignite.internal.util.offheap.unsafe.GridUnsafePartitionedMap
Tests to remove:
- GridByteArrayWrapper
- GridOffHeapMapAbstractSelfTest
- GridOffHeapMapPerformanceAbstractTest
- GridOffHeapPartitionedMapAbstractSelfTest
- GridOffHeapPartitionedMapPerformanceAbstractTest
- GridUnsafeMapSelfTest
- GridUnsafeMapPerformanceTest
- GridUnsafePartitionedMapSelfTest
- GridUnsafePartitionedMapPerformanceTest
- GridUnsafeStripedLruSefTest
Also remove their entries from IgniteUtilSelfTestSuite,
IgnitePerformanceTestSuite and META-INF/classnames.properties.
The classes in module ignite-unsafe stay, because they are still in use:
GridUnsafeMemory, GridOffHeapEvent, GridOffHeapEventListener and
GridOffHeapOutOfMemoryException. GridUnsafeMemorySelfTest stays too.
> Remove unused GridOffHeapProcessor and legacy off-heap maps
> -----------------------------------------------------------
>
> Key: IGNITE-29225
> URL: https://issues.apache.org/jira/browse/IGNITE-29225
> Project: Ignite
> Issue Type: Task
> Reporter: Dmitry Werner
> Assignee: Dmitry Werner
> Priority: Minor
> Labels: ise, tech-debt
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GridOffHeapProcessor has had no callers since Ignite 2.0, when the
> page-memory architecture replaced the old off-heap storage. It was the only
> production user of the legacy off-heap map implementations in
> org.apache.ignite.internal.util.offheap (module ignite-core). Those maps are
> now referenced only by their own tests. Removing the maps also leaves part of
> GridUnsafeMemory (module ignite-unsafe) without callers.
> Classes to remove (ignite-core):
> - org.apache.ignite.internal.processors.offheap.GridOffHeapProcessor
> - org.apache.ignite.internal.util.offheap.GridOffHeapEvictListener
> - org.apache.ignite.internal.util.offheap.GridOffHeapMap
> - org.apache.ignite.internal.util.offheap.GridOffHeapMapFactory
> - org.apache.ignite.internal.util.offheap.GridOffHeapPartitionedMap
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLru
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLruPoller
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeMap
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafePartitionedMap
> Classes to remove (ignite-unsafe):
> - org.apache.ignite.internal.util.offheap.GridOffHeapEvent
> - org.apache.ignite.internal.util.offheap.GridOffHeapEventListener
> Tests to remove:
> - GridByteArrayWrapper
> - GridOffHeapMapAbstractSelfTest
> - GridOffHeapMapPerformanceAbstractTest
> - GridOffHeapPartitionedMapAbstractSelfTest
> - GridOffHeapPartitionedMapPerformanceAbstractTest
> - GridUnsafeMapSelfTest
> - GridUnsafeMapPerformanceTest
> - GridUnsafePartitionedMapSelfTest
> - GridUnsafePartitionedMapPerformanceTest
> - GridUnsafeStripedLruSefTest
> Unused members to remove from GridUnsafeMemory:
> - event listener support: the lsnr field, listen() and the onEvent() calls in
> allocate0()/release0()
> - allocate(long, boolean)
> - allocateSystem(), releaseSystem(), systemAllocatedSize() and the
> sysAllocated counter
> - putOffHeap(), removeOffHeap(), get(long)
> - unlimited(), freeSize()
> - the FREE constant
> Also remove the matching entries from IgniteUtilSelfTestSuite,
> IgnitePerformanceTestSuite and META-INF/classnames.properties.
> GridUnsafeMemory itself stays because it is still used by the Lucene
> full-text index in ignite-indexing. GridOffHeapOutOfMemoryException stays
> because PageMemoryNoStoreImpl and PagePool use it. GridUnsafeMemorySelfTest
> stays unchanged.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
