[
https://issues.apache.org/jira/browse/IGNITE-29225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134147#comment-18134147
]
Ignite TC Bot commented on IGNITE-29225:
----------------------------------------
{panel:title=Branch: [pull/13768/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13768/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9453153&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9453153
rerunBuildIds=none{color}
> Remove unused GridOffHeapProcessor and legacy off-heap maps
> -----------------------------------------------------------
>
> Key: IGNITE-29225
> URL: https://issues.apache.org/jira/browse/IGNITE-29225
> Project: Ignite
> Issue Type: Task
> Reporter: Dmitry Werner
> Assignee: Dmitry Werner
> Priority: Minor
> Labels: ise, tech-debt
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GridOffHeapProcessor has had no callers since Ignite 2.0, when the
> page-memory architecture replaced the old off-heap storage. It was the only
> production user of the legacy off-heap map implementations in
> org.apache.ignite.internal.util.offheap (module ignite-core). Those maps are
> now referenced only by their own tests. Once the maps are gone, the event
> listener support and part of the API of GridUnsafeMemory (module
> ignite-grid-unsafe) have no callers left. A few other GridUnsafeMemory
> members were already unused.
> Classes to remove (ignite-core):
> - org.apache.ignite.internal.processors.offheap.GridOffHeapProcessor
> - org.apache.ignite.internal.util.offheap.GridOffHeapEvictListener
> - org.apache.ignite.internal.util.offheap.GridOffHeapMap
> - org.apache.ignite.internal.util.offheap.GridOffHeapMapFactory
> - org.apache.ignite.internal.util.offheap.GridOffHeapPartitionedMap
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLru
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeLruPoller
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafeMap
> - org.apache.ignite.internal.util.offheap.unsafe.GridUnsafePartitionedMap
> Classes to remove (ignite-grid-unsafe):
> - org.apache.ignite.internal.util.offheap.GridOffHeapEvent
> - org.apache.ignite.internal.util.offheap.GridOffHeapEventListener
> Tests to remove:
> - GridByteArrayWrapper
> - GridOffHeapMapAbstractSelfTest
> - GridOffHeapMapPerformanceAbstractTest
> - GridOffHeapPartitionedMapAbstractSelfTest
> - GridOffHeapPartitionedMapPerformanceAbstractTest
> - GridUnsafeMapSelfTest
> - GridUnsafeMapPerformanceTest
> - GridUnsafePartitionedMapSelfTest
> - GridUnsafePartitionedMapPerformanceTest
> - GridUnsafeStripedLruSefTest
> Unused members to remove from GridUnsafeMemory:
> - event listener support: the lsnr field, listen() and the onEvent() calls in
> allocate0()/release0()
> - allocateSystem(), releaseSystem(), systemAllocatedSize() and the
> sysAllocated counter
> - freeSize()
> - already unused: allocate(long, boolean), putOffHeap(), removeOffHeap(),
> get(long), unlimited() and the FREE constant
> Also remove the matching entries from IgniteUtilSelfTestSuite,
> IgnitePerformanceTestSuite and META-INF/classnames.properties.
> GridUnsafeMemory itself stays because it is still used by the Lucene
> full-text index in ignite-indexing. GridOffHeapOutOfMemoryException stays
> because PageMemoryNoStoreImpl and PagePool use it. GridUnsafeMemorySelfTest
> stays unchanged.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
