[ 
https://issues.apache.org/jira/browse/IGNITE-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608783#comment-15608783
 ] 

Igor Sapego edited comment on IGNITE-3987 at 10/26/16 3:32 PM:
---------------------------------------------------------------

The problem is there is no additional information in the exception we are 
getting on the Java side. In most cases we get something like this:
{noformat}
Failed to execute SQL query [reqId=2, req=OdbcQueryExecuteRequest 
[cacheName=cache, sqlQry=SELECT a FROM B, args=[]]]
javax.cache.CacheException: class org.apache.ignite.IgniteException: Failed to 
parse query: SELECT a FROM B
        at 
org.apache.ignite.internal.processors.cache.IgniteCacheProxy.query(IgniteCacheProxy.java:740)
        at 
org.apache.ignite.internal.processors.odbc.OdbcRequestHandler.executeQuery(OdbcRequestHandler.java:193)
        at 
org.apache.ignite.internal.processors.odbc.OdbcRequestHandler.handle(OdbcRequestHandler.java:104)
        at 
org.apache.ignite.internal.processors.odbc.OdbcNioListener.onMessage(OdbcNioListener.java:124)
        at 
org.apache.ignite.internal.processors.odbc.OdbcNioListener.onMessage(OdbcNioListener.java:33)
        at 
org.apache.ignite.internal.util.nio.GridNioFilterChain$TailFilter.onMessageReceived(GridNioFilterChain.java:270)
        at 
org.apache.ignite.internal.util.nio.GridNioFilterAdapter.proceedMessageReceived(GridNioFilterAdapter.java:107)
        at 
org.apache.ignite.internal.util.nio.GridNioAsyncNotifyFilter$3.body(GridNioAsyncNotifyFilter.java:95)
        at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
        at 
org.apache.ignite.internal.util.worker.GridWorkerPool$1.run(GridWorkerPool.java:70)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
Caused by: class org.apache.ignite.IgniteException: Failed to parse query: 
SELECT a FROM B
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.queryTwoStep(GridQueryProcessor.java:749)
        at 
org.apache.ignite.internal.processors.cache.IgniteCacheProxy.query(IgniteCacheProxy.java:728)
        ... 12 more
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to parse 
query: SELECT a FROM B
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.executeQuery(GridQueryProcessor.java:1695)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.queryTwoStep(GridQueryProcessor.java:742)
        ... 13 more
Caused by: class 
org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to parse 
query: SELECT a FROM B
        at 
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.queryTwoStep0(IgniteH2Indexing.java:1887)
        at 
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.queryTwoStep(IgniteH2Indexing.java:1793)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor$2.applyx(GridQueryProcessor.java:744)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor$2.applyx(GridQueryProcessor.java:742)
        at 
org.apache.ignite.internal.util.lang.IgniteOutClosureX.apply(IgniteOutClosureX.java:36)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.executeQuery(GridQueryProcessor.java:1672)
        ... 14 more
{noformat}

In this particular case, for example, we do not have table "B", nor we have 
column "a". So, I guess, we need to implement this on SQL level and not on ODBC.



was (Author: isapego):
The problem is there is no additional information in the exception we are 
getting on the Java side. In most cases we get something like this:
{noformat}
Failed to execute SQL query [reqId=2, req=OdbcQueryExecuteRequest 
[cacheName=cache, sqlQry=SELECT a FROM B, args=[]]]
javax.cache.CacheException: class org.apache.ignite.IgniteException: Failed to 
parse query: SELECT a FROM B
        at 
org.apache.ignite.internal.processors.cache.IgniteCacheProxy.query(IgniteCacheProxy.java:740)
        at 
org.apache.ignite.internal.processors.odbc.OdbcRequestHandler.executeQuery(OdbcRequestHandler.java:193)
        at 
org.apache.ignite.internal.processors.odbc.OdbcRequestHandler.handle(OdbcRequestHandler.java:104)
        at 
org.apache.ignite.internal.processors.odbc.OdbcNioListener.onMessage(OdbcNioListener.java:124)
        at 
org.apache.ignite.internal.processors.odbc.OdbcNioListener.onMessage(OdbcNioListener.java:33)
        at 
org.apache.ignite.internal.util.nio.GridNioFilterChain$TailFilter.onMessageReceived(GridNioFilterChain.java:270)
        at 
org.apache.ignite.internal.util.nio.GridNioFilterAdapter.proceedMessageReceived(GridNioFilterAdapter.java:107)
        at 
org.apache.ignite.internal.util.nio.GridNioAsyncNotifyFilter$3.body(GridNioAsyncNotifyFilter.java:95)
        at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
        at 
org.apache.ignite.internal.util.worker.GridWorkerPool$1.run(GridWorkerPool.java:70)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
Caused by: class org.apache.ignite.IgniteException: Failed to parse query: 
SELECT a FROM B
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.queryTwoStep(GridQueryProcessor.java:749)
        at 
org.apache.ignite.internal.processors.cache.IgniteCacheProxy.query(IgniteCacheProxy.java:728)
        ... 12 more
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to parse 
query: SELECT a FROM B
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.executeQuery(GridQueryProcessor.java:1695)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.queryTwoStep(GridQueryProcessor.java:742)
        ... 13 more
Caused by: class 
org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to parse 
query: SELECT a FROM B
        at 
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.queryTwoStep0(IgniteH2Indexing.java:1887)
        at 
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.queryTwoStep(IgniteH2Indexing.java:1793)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor$2.applyx(GridQueryProcessor.java:744)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor$2.applyx(GridQueryProcessor.java:742)
        at 
org.apache.ignite.internal.util.lang.IgniteOutClosureX.apply(IgniteOutClosureX.java:36)
        at 
org.apache.ignite.internal.processors.query.GridQueryProcessor.executeQuery(GridQueryProcessor.java:1672)
        ... 14 more
{noformat}

In this particular case, for example, we do not have table "B", nor column "a". 
So, I guess, we need to implement this on SQL level and not on ODBC.


> ODBC: Improve error output when query parsing failed.
> -----------------------------------------------------
>
>                 Key: IGNITE-3987
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3987
>             Project: Ignite
>          Issue Type: Task
>          Components: odbc
>    Affects Versions: 1.7
>            Reporter: Vladimir Ozerov
>            Assignee: Vladimir Ozerov
>            Priority: Minor
>             Fix For: 1.8
>
>
> Currently if an error occurred we only prints the top-level message, like 
> "Failed to parse query ...". The problem is that we do not explain users why 
> exactly it failed.
> Looks like we need to add more info on Java side when sending error response.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to