[ 
https://issues.apache.org/jira/browse/IGNITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632259#comment-15632259
 ] 

Semen Boikov commented on IGNITE-3075:
--------------------------------------

Hi Konstantin,

Here are my comments:
- now forceTransformBackups mode is not supported, so 
GridDhtAtomicSingleUpdateTransformRequest is not needed
- GridDhtAtomicSingleUpdateRequest.updateCntrs - there can be only one update 
counter
- GridDhtAtomicSingleUpdateRequest now it have both 'keepBinary' and 'flags' 
fields, let's keep only 'flags'
- in GridDhtAtomicSingleUpdateRequest there can be only 'near' or only 
'regular' key/val pair
- let's remove ttl, conflict fields from GridDhtAtomicSingleUpdateRequest (use 
regualr request if there are non-default values for these fields)
- GridDhtAtomicSingleUpdateRequest.keys() creates collection, now I see only 
one call of 'GridDhtAtomicSingleUpdateRequest .keys()', try to get rid of this 
method

Thanks!

> Implement single key-value pair DHT request/response for ATOMIC cache.
> ----------------------------------------------------------------------
>
>                 Key: IGNITE-3075
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3075
>             Project: Ignite
>          Issue Type: Task
>          Components: cache
>    Affects Versions: 1.5.0.final
>            Reporter: Vladimir Ozerov
>            Assignee: Konstantin Dudkov
>              Labels: performance
>             Fix For: 1.8
>
>
> Need to implement specialized light-weight version of DHT request/response to 
> make the most common case - single KV update - more performant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to