[ 
https://issues.apache.org/jira/browse/IGNITE-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697123#comment-15697123
 ] 

Roman Shtykh edited comment on IGNITE-4244 at 11/27/16 4:49 AM:
----------------------------------------------------------------

[~anovikov]
The behavior for starting with Long.MAX_VALUE will have to produce "ERR 
increment or decrement would overflow". But if you set larger than that, "ERR 
value is not an integer or out of range."(https://redis.io/commands/incr)  I 
fixed that, thank you!

Do you think this fix can be merged to the master branch? I would like to see 
it in 1.8.0 release.


was (Author: roman_s):
[~anovikov]
Andrey, an error message starting with ERR (which is {{JedisDataException}} for 
jedis 
https://github.com/xetorthio/jedis/blob/master/src/test/java/redis/clients/jedis/tests/commands/StringValuesCommandsTest.java#L195).
This is covered by the unit test in RedisProtocolSelfTest#testIncrDecr lines 
299-307.

Do you think this fix can be merged to the master branch? I would like to see 
it in 1.8.0 release.

> Redis INCR/DECR to operate on AtomicLong.
> -----------------------------------------
>
>                 Key: IGNITE-4244
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4244
>             Project: Ignite
>          Issue Type: Sub-task
>    Affects Versions: 1.8
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>              Labels: redis
>             Fix For: 1.8
>
>
> "The INCR command parses the string value as an integer, increments it by 
> one, and finally sets the obtained value as the new value. " 
> http://redis.io/topics/data-types-intro



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to