[ https://issues.apache.org/jira/browse/IGNITE-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810231#comment-15810231 ]
ASF GitHub Bot commented on IGNITE-4530: ---------------------------------------- GitHub user zshamrock opened a pull request: https://github.com/apache/ignite/pull/1404 IGNITE-4530 Add support to provide AWSCredentialsProvider to TcpDisco… …veryS3IpFinder in addition to just AWSCredentials Addressing https://issues.apache.org/jira/browse/IGNITE-4530. Just to review by the maintainers whether it meets all the project criteria. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zshamrock/ignite ignite-4530 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1404.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1404 ---- commit eec10ca32de8311c1d6eaea337cf5511b9bfc2d0 Author: Aliaksandr Kazlou <aliaksandr.kaz...@gmail.com> Date: 2017-01-08T23:42:12Z IGNITE-4530 Add support to provide AWSCredentialsProvider to TcpDiscoveryS3IpFinder in addition to just AWSCredentials ---- > Passing AWSCredentialsProvider to TcpDiscoveryS3IpFinder > -------------------------------------------------------- > > Key: IGNITE-4530 > URL: https://issues.apache.org/jira/browse/IGNITE-4530 > Project: Ignite > Issue Type: Bug > Reporter: Denis Magda > Assignee: Aliaksandr Kazlou > > {{TcpDiscoveryS3IpFinder}} accepts credentials in a form of > {{AWSCredentials}} only. This might not be enough for all the cases. In a > situation when the credentials get expired a special instance of > {{AWSCredentialsProvider}} can renew them automatically. > However, the credentials will not be updated if {{StaticCredentialsProvider}} > is used. This provider is created automatically if user provides raw > {{AWSCredentials}}. > We need to add new method to {{TcpDiscoveryS3IpFinder}} that will accept > {{AWSCredentialsProvider}}: > {code} > public void setAwsCredentialsProvider(AWSCredentialsProvider provider) { > {code} > A new test has to be added to {{TcpDiscoveryS3IpFinderSelfTest}} as well. > For more details refer to a discussion on the user list: > http://apache-ignite-users.70518.x6.nabble.com/Old-AWS-SDK-version-why-td9824.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)