[ 
https://issues.apache.org/jira/browse/IGNITE-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843655#comment-15843655
 ] 

Denis Magda commented on IGNITE-4374:
-------------------------------------

Guys,

The report at the current state looks extensive for me because it's split into 
different sections visually.

I would suggest placing everything under the existing performance section 
controlled by the same single flag. For instance, this how the output might be 
presented to the user.

{code}
[15:09:14] Performance suggestions for grid  (fix if possible)
[15:09:14] To disable, set -DIGNITE_PERFORMANCE_SUGGESTIONS_DISABLED=true
[15:09:14]   ^-- Disable grid events (remove 'includeEventTypes' from 
configuration)
[15:09:14]   ^-- Enable G1 Garbage Collector (add '-XX:+UseG1GC' paramter to 
JVM options)
[15:09:14]   ^-- Enable server mode for JVM (add '-server' paramter to JVM 
options)
[15:09:14]   ^-- Reduce Java heap size to prevent long GC pauses (use off-heap 
caches and tune '-Xmx' parameter).
[15:09:14]   ^-- {another suggestion}
[15:09:14]   ^-- {another suggestion}
[15:09:14] Refer to this page for more performance suggestions: 
https://apacheignite.readme.io/docs/jvm-and-system-tuning
{code}

How do you like this output? I find it more user friendly and clearer.

Also, I thought over a bit and think that we don't need to show GC logs 
suggestions at all. They are not related to performance but to the debugging 
meaning that it's absolutely fine to go in production if you don't enable GC 
logs. 

> Ignite should validate JVM and OS configuration and output warning in log
> -------------------------------------------------------------------------
>
>                 Key: IGNITE-4374
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4374
>             Project: Ignite
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Yakov Zhdanov
>            Assignee: Vyacheslav Daradur
>         Attachments: x32_not_optimized.png, x32_optimized.png, 
> x64_not_optimized.png, x64_optimized.png
>
>
> Currently we have GridPerformanceSuggestions that output suggestions to logs 
> on Ignite start on how Ignite can be improved.
> I suggest to go a little bit deeper and validate more configuration options 
> and add validation for JVM and OS settings.
> Ignite should output warning if:
> * GC logging is not enabled
> * MaxDirectMemorySize is not set (-XX:MaxDirectMemorySize)
> * Heap size is greater than 30,5G and JVM cannot use compressed oops
> * Any of the recommended OS setting described here 
> https://apacheignite.readme.io/docs/jvm-and-system-tuning are not properly 
> set 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to