[ 
https://issues.apache.org/jira/browse/IGNITE-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863528#comment-15863528
 ] 

Vladimir Ozerov commented on IGNITE-4158:
-----------------------------------------

[~daradurvs],
I have mixed feelings after review of this ticket :-) On the one hand this is 
an example of great in-depth implementation of rather complex logic. Thank you 
for this contribution. On the other hand it demonstrates how difficult it is to 
add new special types to binary protocol. You have to change dozes of classes, 
often with duplicated code. We definitely should spend some time on refactoring 
of the whole binary infrastructure, because otherwise it will become (already?) 
unmanageable very soon.

I added some missing parts (handling in binary builder and ODBC processor), and 
merged the fix into {{ignite-2.0}} branch. Please take a look on final commit 
{{00dd3d8}} if you are curios what was missed.

Also I created related tickets for .NET, CPP and ODBC parts.

Cheers,
Vladimir.


> Implement Time type for binary protocol.
> ----------------------------------------
>
>                 Key: IGNITE-4158
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4158
>             Project: Ignite
>          Issue Type: Task
>          Components: binary
>    Affects Versions: 1.7
>            Reporter: Igor Sapego
>            Assignee: Vyacheslav Daradur
>             Fix For: 2.0
>
>
> Currently there is no support for Time type in binary protocol. However, this 
> type is a commonly used SQL type, which is used in, for example, ODBC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to