[
https://issues.apache.org/jira/browse/IGNITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962129#comment-15962129
]
Valentin Kulichenko commented on IGNITE-4812:
---------------------------------------------
[~alpert], I merged your change. However I had to make some changes:
* Exception handling was still incorrect. In case of remote query, exception
should be thrown on remote node(s), because it's possible that client will
still have no-op SPI, while servers will have correct implementation.
* In addition, internal components should never throw unchecked
{{IgniteException}}. You should use {{IgniteCheckedException}} instead and
convert it in the API facade.
* Any new file you add should have proper header with Apache 2.0 license.
Please review these changes to make sure you understand how to do this properly
in the future.
Thanks for the contribution!
> Disable EventStorageSpi by default
> ----------------------------------
>
> Key: IGNITE-4812
> URL: https://issues.apache.org/jira/browse/IGNITE-4812
> Project: Ignite
> Issue Type: Bug
> Components: general
> Affects Versions: 1.9
> Reporter: Valentin Kulichenko
> Assignee: Alper Tekinalp
> Fix For: 2.0
>
>
> Current default implementation of {{EventStorageSpi}} is
> {{MemoryEventStorageSpi}}. It consumes a lot of memory, while is used only
> for events querying (i.e. not listening), which is a fairly rare use case.
> Need to:
> * Introduce {{NoOpEventStorageSpi}}.
> * Make {{NoOpEventStorageSpi}} the default one.
> * Throw an exception when {{IgniteEvents#localQuery}} or {{#remoteQuery}}
> method is called with default setting. Exception message should explain how
> to fix it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
