[ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965880#comment-15965880 ]
Andrey Gura commented on IGNITE-4795: ------------------------------------- Code changes and TC look good to me. Merged into master branch. [~SomeFire], thanks a lot for your contribution. > Inherit TransactionException and update Javadoc > ----------------------------------------------- > > Key: IGNITE-4795 > URL: https://issues.apache.org/jira/browse/IGNITE-4795 > Project: Ignite > Issue Type: Improvement > Components: cache, SQL, website > Affects Versions: 1.8 > Reporter: Alexandr Kuramshin > Assignee: Ryabov Dmitrii > Labels: documentation, important > Fix For: 2.0 > > > Understanding transactional behaviour is not clear in Javadoc at this point > of time. Even after reading website some doubt remain. > Proposal. > 1. Create {{TransactionException}} as the marker of transactional methods and > inherit from it all the existed transactional exceptions like > {{TransactionTimeoutException}}, {{TransactionRollbackException}}, > {{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc. > 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) > as throwing the base {{TransactionException}}. Comment all the > {{IgniteCache}} methods whether they are transactional or not, add {{@see > TransactionException}} annotation. > 3. Make extensive documentation in the header of {{TransactionException}} to > get understanding of transactional and non-transactional methods behaviour. > 4. Update website and Javadoc to clarify the fact that {{put}} value is > cached within the transaction and affects successive {{get}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)