[ https://issues.apache.org/jira/browse/IGNITE-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030995#comment-16030995 ]
Sergey Chugunov edited comment on IGNITE-5124 at 5/31/17 11:16 AM: ------------------------------------------------------------------- [~agoncharuk], [~ptupitsyn] guys please review my changes, pull request is available here: https://github.com/apache/ignite/pull/2045 was (Author: sergey-chugunov): pull request is available here: https://github.com/apache/ignite/pull/2045 > MemoryMetrics API Improvements > ------------------------------ > > Key: IGNITE-5124 > URL: https://issues.apache.org/jira/browse/IGNITE-5124 > Project: Ignite > Issue Type: Task > Components: general > Reporter: Denis Magda > Assignee: Sergey Chugunov > Labels: important > Fix For: 2.1 > > > * Ignite.memoryMetrics() returns a collection of metrics. However, it’s > unclear what exactly the collection includes. Is every element of the > collection is a latest snapshot of a specific memory region defined by memory > policy and the the total size of the collection is equal to the total number > of such regions configured on a node? This has to be clarified in java doc > before 2.0 release. > * I would have Ignite.memoryMetrics(name) methods that will return the > metrics for a concrete region configured by memory policy. It’s fine to add > the method under 2.1 (create a ticket). > * I would add “setRateInterval” and “setSubIntervals” methods to > MemoryPolicyConfiguration because now I have to get a JMX bean if to want to > change the parameter. Again, feel free do this under 2.0 or move to 2.1 if > there is no time for that. > Original discussion: > http://apache-ignite-developers.2346864.n4.nabble.com/MemoryMetrics-interface-inconsistencies-td17156.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)