[
https://issues.apache.org/jira/browse/IGNITE-5328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032757#comment-16032757
]
Vladimir Ozerov commented on IGNITE-5328:
-----------------------------------------
[~al.psc], my comments:
1) {{GridSqlQueryParser.parseCreateTable}} - please confirm that both
{{backups=1}} and {{backups = 1}} will work, as I do not see calls to
String.trim(). We need tests for this.
2) No "param" abbreviation in error messages. "parameter" should be used
3) Please make sure that error message follows our conventions: it should be
either "GENERAL_CAUSE (OPTIONAL_SPECIFICATION): SINGLE_PARAM" or "GENERAL_CAUSE
(OPTIONAL_SPECIFICATION) \[param1=val1, param2=val2, ...\]". E.g.:
{code}
throw new IgniteSQLException("Invalid param syntax (key[=value] expected): " +
p);
{code}
4) {{GridSqlQueryParser.processExtraParam}} - {{backups=}} should raise
exception. Will that happen in current implementation? Same question for
atomicity.
5) {{GridSqlQueryParser}}: {{parseIntParam}} and {{parseEnumParam}} should
throw {{PARSING}} exception.
6) Lets rename "cacheTemplate" parameter to "template".
7) Negative backups number should raise an exception.
> Support cache atomicity mode for CREATE TABLE
> ---------------------------------------------
>
> Key: IGNITE-5328
> URL: https://issues.apache.org/jira/browse/IGNITE-5328
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Vladimir Ozerov
> Assignee: Alexander Paschenko
> Fix For: 2.1
>
>
> Users should be able to set atomicity mode through "WITH" synthax.
> Property name: {{atomicityMode}}
> Allowed values (case insensitive): {{atomic}}, {{transactional}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
