[ 
https://issues.apache.org/jira/browse/IGNITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133022#comment-16133022
 ] 

ASF GitHub Bot commented on IGNITE-3196:
----------------------------------------

GitHub user alamar opened a pull request:

    https://github.com/apache/ignite/pull/2484

    Backport IGNITE-3196

    Add support for BigDecimals with negative scale in BinaryMarshaller

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-1.7.15

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2484
    
----
commit a62a0136d295486d95c6e2ab5bba88270d831753
Author: dkarachentsev <dkarachent...@gridgain.com>
Date:   2016-11-02T16:07:45Z

    GG-11655 - Fix merge

commit 348593986b56ddfcec4a4455e49d9b279eae4dc8
Author: devozerov <voze...@gridgain.com>
Date:   2016-11-05T10:28:03Z

    Merge branch 'ignite-1.7.3' into ignite-1.7.4

commit 175da6b7e394dd76c27d5155ff98a5b2ef03bb9d
Author: tledkov-gridgain <tled...@gridgain.com>
Date:   2016-11-07T06:16:58Z

    IGNITE-3432:  check data/meta cache names are different for different IGFS 
instances. This closes #1201

commit ead15193899d08f41491166003cabed0560f0c59
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-07T07:49:03Z

    IGNITE-4028 Get rid of OP_META in PlatformAbstractTarget
    
    This closes #1192

commit 40ef2f5ae42826fe8fd077e3013e8f55c8512bdd
Author: Dmitriy Govorukhin <dgovoruk...@gridgain.com>
Date:   2016-11-07T09:09:41Z

    ignite-4178 support permission builder

commit df670c7d64046d282c053f296c47a4743c58c8b1
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-07T09:40:00Z

    IGNITE-4118 .NET: Optimistic transaction example
    
    This closes #1200

commit 474f22fda4c7cf4d7b2623c451cd7c10f0d8c636
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-07T09:55:20Z

    IGNITE-4119 .NET: add TransactionDeadlockException

commit fc7ce5a4d72145f2e8a86debeda264ef0a5b37e3
Author: isapego <isap...@gridgain.com>
Date:   2016-11-07T10:26:05Z

    IGNITE-4090: Added flags so stdint and limits can be used in C++.

commit a98804a249496ba9bafbc96daa7aaf25b3d36724
Author: Igor Sapego <isap...@gridgain.com>
Date:   2016-11-07T11:00:00Z

    IGNITE-4113: Added tests. Added Statement::Set/GetAttribute.

commit b1c7c9bb95c900083702d0ba0362edf3aea5a7b4
Author: sboikov <sboi...@gridgain.com>
Date:   2016-11-07T12:40:36Z

    GG-11360 - Implement SQL queries cancellation
    Fix for commit 80abd1b: for distributed joins need always send cancel 
request.

commit 319014de075c80fb15e58172cc24e35ce16b56cf
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-07T14:53:40Z

    IGNITE-4132 .NET: Improve BinaryConfiguration documentation

commit 950bad474ef29f9b808e74034c49a69d57eb2740
Author: dkarachentsev <dkarachent...@gridgain.com>
Date:   2016-11-08T11:03:34Z

    GG-11655 - Restore service compatibility with releases before 1.5.30.

commit 3d19bfc2b66574e3945ce17c7a4dfe77d0070b8d
Author: dkarachentsev <dkarachent...@gridgain.com>
Date:   2016-11-08T11:04:36Z

    Merge remote-tracking branch 'origin/ignite-1.6.11' into ignite-1.6.11

commit 1612b6d66fed032182a41e90da71e6b986ae087b
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-08T11:07:54Z

    .NET: Fix minor analysis warnings

commit e821dc0083003bc81058b1cb223d8a8a2ee44daf
Author: Dmitriy Govorukhin <dgovoruk...@gridgain.com>
Date:   2016-11-08T12:09:21Z

    IGNITE-2079 (revert commit) GridCacheIoManager eats exception trail if it 
falls into the directed case

commit c2c82ca44befe4570325dd6cf2ba885e0d90596c
Author: Dmitriy Govorukhin <dgovoruk...@gridgain.com>
Date:   2016-11-08T12:10:10Z

    Merge remote-tracking branch 'professional/ignite-1.6.11' into ignite-1.6.11

commit 865bbcf0f41a0c4944e0928f1758d43a0eae82c5
Author: Dmitriy Govorukhin <dgovoruk...@gridgain.com>
Date:   2016-11-08T12:18:29Z

    Revert "Merge remote-tracking branch 'professional/ignite-1.6.11' into 
ignite-1.6.11"
    
    This reverts commit c2c82ca44befe4570325dd6cf2ba885e0d90596c, reversing
    changes made to e821dc0083003bc81058b1cb223d8a8a2ee44daf.

commit 9726421ff9efb2b19813b2fd6ad27a3728b5ab1a
Author: Dmitriy Govorukhin <dgovoruk...@gridgain.com>
Date:   2016-11-08T12:59:00Z

      Revert  Revert  Merge remote-tracking branch 'professional/ignite-1.6.11'

commit 5a3a1960fff1dcf32961c45c0ba5149d6748d2fc
Author: Igor Sapego <isap...@gridgain.com>
Date:   2016-11-08T14:36:35Z

    Added license header.

commit f697fb5786fb4ce15f581c465ff0dcb3d2bb7b14
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-08T16:13:48Z

    IGNITE-4185 .NET: Fix NullReferenceException in IgniteOutputCacheProvider 
when igniteConfiguration is missing

commit 69487f2c375010737311af65750a519b403fc17f
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date:   2016-11-08T16:38:28Z

    .NET: Fix error messages when IgniteConfigurationSection content is missing

commit d88f422aeb02738d676d86ce416551b805ad154e
Author: Andrey Novikov <anovi...@apache.org>
Date:   2016-11-09T07:25:38Z

    GG-11028 Fixed resolving of host name.

commit ac660dcaa5bf8eb20e7dd4e442e97c1cf548a827
Author: Igor Sapego <isap...@gridgain.com>
Date:   2016-11-09T12:29:06Z

    IGNITE-4183: ODBC Fixed null-values fetching issue.

commit cdae2ab76d403aef9a0bd209fc7497dc6cfdfc08
Author: Igor Sapego <isap...@gridgain.com>
Date:   2016-11-09T13:25:30Z

    IGNITE-3873: Added WiX script to generate ODBC installer.

commit 1093819ac0f3e7a0faacde59919117b8977e6d5b
Author: Igor Sapego <isap...@gridgain.com>
Date:   2016-11-09T15:19:01Z

    IGNITE-4201: Fixed version fix maven step.

commit bac0cba7fddd412dfbff98163afbc15d81d5e0d4
Author: Dmitriy Govorukhin <dgovoruk...@gridgain.com>
Date:   2016-11-10T06:02:41Z

    ignite-4044  always authenticate local node

commit 26daa57ca82254d68ac04a7b33223c6eb5ade0e4
Author: sboikov <sboi...@gridgain.com>
Date:   2016-11-10T08:17:29Z

    Fixed javadoc.

commit 8b59f4e76138e08e80aa219c1a9cf0c3df6fdb4b
Author: Andrey V. Mashenkov <andrey.mashen...@gmail.com>
Date:   2016-11-10T11:43:00Z

    Backport commit of the following:
    
    commit 612eb3daffe608995aac28eed019b3e6ef9d66d3
    Author: Aleksei Scherbakov <alexey.scherbak...@gmail.com>
    Date:   Fri Aug 19 13:28:39 2016 +0300
    
        ignite-2795 Support 'copyOnRead' for SQL queries

commit b7499828c928e02e8e554f960f3754e4d08bfbe0
Author: Anton Vinogradov <a...@apache.org>
Date:   2016-11-10T13:10:21Z

    IGNITE-500 CacheLoadingConcurrentGridStartSelfTest fails (DataStreamer data 
loss at unstable topology in !allowOverwrite mode fixed)

commit baa752660c6eddf27d15a812252b01b5872385de
Author: iveselovskiy <iveselovs...@gridgain.com>
Date:   2016-11-10T15:47:09Z

    IGNITE-4208: Hadoop: Fixed a bug preventing normal secondary file system 
start. This closes #1228.

----


> Marshaling works wrong for the BigDecimals that have negative scale
> -------------------------------------------------------------------
>
>                 Key: IGNITE-3196
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3196
>             Project: Ignite
>          Issue Type: Bug
>          Components: binary
>    Affects Versions: 1.6
>            Reporter: Igor Sapego
>            Assignee: Vyacheslav Daradur
>             Fix For: 2.0
>
>
> Current marshalling procedure of the {{BigDecimal}} assumes that the scale of 
> the {{BigDecimal}} value is always more than or equal to zero. However, scale 
> [can be 
> negative|https://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#scale()].
> This leads to invalid results if we try to marshal-unmarshal {{BigDecimal}} 
> that has a negative scale.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to