[
https://issues.apache.org/jira/browse/IGNITE-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149099#comment-16149099
]
ASF GitHub Bot commented on IGNITE-6233:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/2570
IGNITE-6233 .NET: Extract type codes to a separate class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-6233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2570.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2570
----
commit e96152bd78fb79931867fd1a57eb5ab3cfb0c4f3
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:39:14Z
Extract BinaryTypeId class
commit f77846d51308646b27c3332e770249d04e9ddf62
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:46:00Z
Replacing usages
commit f7aeb1245287f49a2fae658960fe1abc3ade2abc
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:46:26Z
wip
commit d9e587d8ef3c3d5f4a84847805f4d75f44fa7e66
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:46:58Z
wip
commit 542966276de65a5b6eed20bd7d38d70b9e1b9b20
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:47:24Z
Compilation fixed
commit e445f19edcc228cff1bea04d1b5d7a3540a5759e
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:51:48Z
Simplify naming
commit c9e4fb2f906f39c69ef5f6cb9372d12ed7965261
Author: Pavel Tupitsyn <ptupit...@apache.org>
Date: 2017-08-31T14:56:58Z
minors
----
> .NET: Extract type codes to a separate class
> --------------------------------------------
>
> Key: IGNITE-6233
> URL: https://issues.apache.org/jira/browse/IGNITE-6233
> Project: Ignite
> Issue Type: Improvement
> Components: platforms
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Labels: .NET
> Fix For: 2.3
>
>
> {{BinaryUtils}} class is a mess. First candidate for extraction is a set of
> type codes ({{TypeByte}} etc). {{BinarySystemHandlers.GetTypeId}} should be
> moved to the same class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
