[ 
https://issues.apache.org/jira/browse/IGNITE-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180187#comment-16180187
 ] 

Roman Shtykh commented on IGNITE-6444:
--------------------------------------

[~agoncharuk] Thanks for the explanation!
Btw, I found _copyOnRead_ was set to false for optimization 
https://issues.apache.org/jira/browse/IGNITE-3569, so I decided not to set it 
to true, but introduce the validation for public caches only, as in the pull 
request. What do you think?

Also, I modified {{IgniteCacheCopyOnReadDisabledAbstractTest}} with 
_setOnheapCacheEnabled(true)_. But it fails with EntryProcessor with ATOMIC 
cache (TX cache is ok) -- it looks like offheap is called anyway. If you are ok 
with this pull request, I will merge it and create a new JIRA issue for this.

It is weird TeamCity showed no errors before, but it fails for me when I run it 
locally.

> Validate that copyOnRead flag is configured with on-heap cache enabled
> ----------------------------------------------------------------------
>
>                 Key: IGNITE-6444
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6444
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>    Affects Versions: 2.0
>            Reporter: Alexey Goncharuk
>            Assignee: Roman Shtykh
>              Labels: usability
>             Fix For: 2.3
>
>
> Link to the user-list discussion:
> http://apache-ignite-users.70518.x6.nabble.com/Ignite-2-1-0-CopyOnRead-Problem-td17009.html
> It makes sense to validate the flag and print out a warning if on-heap cache 
> is disabled. I do not think that we should prevent node from startup because 
> this may break existing deployments.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to