[ 
https://issues.apache.org/jira/browse/IGNITE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194358#comment-16194358
 ] 

Pavel Tupitsyn commented on IGNITE-6272:
----------------------------------------

[~alexey.tank2], my comments:
1) {{IServices.DeployAll}} should take {{IEnumerable}} instead of 
{{ICollection}}
2) {{ServiceConfiguration.Serialize}} methods should be internal, no need to 
expose them to the users
3) Let's check if any element of {{ICollection<ServiceConfiguration> cfgs}} is 
null and throw {{ArgumentNullException}}
4) {{TODO: think if we can use WriteEnumerable here}} - there is no suitable 
{{WriteEnumerable}} overload (with {{Action<IBinaryRawWriter> writeAction}} or 
something like this). I think it makes sense to create one since this is a very 
common pattern in our code.

> .NET: Propagate multiple services deployment
> --------------------------------------------
>
>                 Key: IGNITE-6272
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6272
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>            Reporter: Denis Mekhanikov
>            Assignee: Alexey Popov
>              Labels: .NET, newbie
>             Fix For: 2.4
>
>
> Multiple services deployment support should be propagated to .NET:
> * {{IgniteServices.deployAll}}
> * {{IgniteServices.deployAllAsync}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to