[ https://issues.apache.org/jira/browse/IGNITE-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256549#comment-16256549 ]
Alexander Menshikov commented on IGNITE-5994: --------------------------------------------- [~shia] You has formed the patch in wrong way. You need to create a PR on GitHub and create a upsource review. Please see HowToContribute page: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow Sorry for a slow answering. Also, I have to say I haven't merge permission so you will have to ask about merge on dev-list. > IgniteInternalCache.invokeAsync().get() can return null > ------------------------------------------------------- > > Key: IGNITE-5994 > URL: https://issues.apache.org/jira/browse/IGNITE-5994 > Project: Ignite > Issue Type: Bug > Components: cache > Affects Versions: 2.1 > Reporter: Alexander Menshikov > Assignee: Zhang Yuan > Priority: Minor > Labels: newbie > Attachments: IgniteCacheSelfTest.java, > master_8629b50d6f_ignite-5994.patch > > > The IgniteInternalCache.invoke() always return an EntryProcessorResult, but > the IgniteInternalCache.invokeAsync().get() can return the null in case when > an EntryProcessor has returned the null. > Code from reproducer: > {noformat} > final EntryProcessor<Object, Object, Object> ep = new EntryProcessor<Object, > Object, Object>() { > @Override > public Object process(MutableEntry<Object, Object> entry, > Object... objects) throws EntryProcessorException { > return null; > } > }; > EntryProcessorResult<Object> result = utilCache.invoke("test", ep); > assertNotNull(result); > assertNull(result.get()); > result = utilCache.invokeAsync("test", ep).get(); > // Assert here!!! > assertNotNull(result); > assertNull(result.get()); > {noformat} > It can be optimization. Nevertheless results of invoke() must be equals with > results of invokeAsync().get(). So there are two options: > 1) To do so would be the invokeAsync(key, ep).get() returned the null too for > the optimization. > 2) Or to do so would be the invoke(key, ep) returned an EntryProcessorResult > for a logical consistency. > NOTE: Don't confuse with IgniteCache.invoke. -- This message was sent by Atlassian JIRA (v6.4.14#64029)