[ 
https://issues.apache.org/jira/browse/IGNITE-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319830#comment-16319830
 ] 

Stanislav Lukyanov commented on IGNITE-7284:
--------------------------------------------

[~vkulichenko], thanks for the feedback.

Yes, I'll be adding the DEV_ONLY now + a few IgniteUtils methods accepting 
markers + applying DEV_ONLY for the serialization warnings mentioned in the 
referenced mail thread.

About the system property, - is it really necessary?
Special-handling DEV_ONLY messages via a property kind of defeats the purpose 
of introducing markers as a general solution for this kind of problem.
Using JUL (or another simplistic logger) as a logging implementation is likely 
to be a deliberate choice not to care too much about the logs. If a user wants 
a finer filtering of the logs, they'll probably be able to use log4j2 (or 
already use it).

We *could* re-implement marker-based filtering for JUL via system properties, 
say by looking up IGNITE_LOG_<marker name> and only printing the message if the 
property is set to true, but enhancing underlying implementations seems to be a 
bit of an overkill.

> Introduce DEV_ONLY marker to IgniteLogger
> -----------------------------------------
>
>                 Key: IGNITE-7284
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7284
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.3
>            Reporter: Valentin Kulichenko
>            Assignee: Stanislav Lukyanov
>             Fix For: 2.4
>
>
> Need to add markers support to {{IgniteLogger}} and then introduce 
> {{DEV_ONLY}} marker for warnings that can be suppressed in prod environments.
> Problem and solution are discussed in more detail here: 
> http://apache-ignite-developers.2346864.n4.nabble.com/Suppressing-quot-development-quot-warning-td25195.html
> Make sure to update Loggers documentation explaining how the parameter works 
> and what's it for:
> https://apacheignite.readme.io/docs/logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to