[ 
https://issues.apache.org/jira/browse/IGNITE-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328969#comment-16328969
 ] 

ASF GitHub Bot commented on IGNITE-7456:
----------------------------------------

GitHub user artemmalykh opened a pull request:

    https://github.com/apache/ignite/pull/3398

    IGNITE-7456: Fix wrong batch logic in distributed MLP training.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-7456

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/3398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3398
    
----
commit 995d781b58b57c4721b3fd92d3867975d652272a
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T13:22:21Z

    IGNITE-7397: Fix cache configuration and reduced trainings count in MLP 
group training test.

commit 123f14ccc8b8c0e27104061b4644876b45a8a123
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T13:23:02Z

    Merge branch 'master-apache' into ignite-7397

commit b2cfa9017b69b8ebfd2bca4143c91315c1fd3a06
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T15:15:01Z

    IGNITE-7350: Moved update calculators from nn package to optimization.

commit 32de402cd6939aba24cec572e42ddc8d90dc3251
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T15:24:33Z

    IGNITE-7350: Moved LossFunctions, fixed some comments.

commit eb1ceb580c418ec91c3e5b42585132b15073aa97
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T16:03:26Z

    IGNITE-7350: Removed in-place changing of update and model in Nesterov 
update calculator.

commit e5d3299c6b344fb2b9c54b6f578cdda2739c7ffa
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T16:07:31Z

    IGNITE-7350: Default implementation for 'withParameters'.

commit b0dc57dcf8e717def820806dab62d50715de02f6
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T16:11:26Z

    IGNITE-7350: Moved some files to appropriate packages.

commit 3badb8aaf899448cf5fb222048a1e5e7fdd247b1
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T16:40:23Z

    IGNITE-7350: Added javadoc.

commit ef6724af220a7a1bdb9523f497787b185621104d
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T20:42:02Z

    IGNITE-7350: Changed todos.

commit 3dc51d7da99512aac5f734d0b8ddde3f33871d48
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T20:53:18Z

    IGNITE-7350: Added javadocs.

commit 20f3d34aaf6f072be60ac8744112f91308540aba
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T21:14:30Z

    IGNITE-7350: Added javadocs.

commit a243d7875b4d33e1d1abab710a8442affeb38119
Author: Artem Malykh <amalykh@...>
Date:   2018-01-12T21:16:08Z

    IGNITE-7350: Added javadocs.

commit 0da733145252fe92f8a894d2364da3695923e40e
Author: Artem Malykh <amalykh@...>
Date:   2018-01-17T16:08:06Z

    IGNITE-7456: Fixed wrong batches logic.

commit fe3ea2d6a7ec9fc97c255c3bbd04bb91bf92ad69
Author: Artem Malykh <amalykh@...>
Date:   2018-01-17T16:09:39Z

    ignite-7456: Some changes to tests.

commit 53aef283e94f61a0ee96549c2bcae9f1fe2bdb4d
Author: Artem Malykh <amalykh@...>
Date:   2018-01-17T16:29:58Z

    Merge branch 'master-apache' into ignite-7456
    
    # Conflicts:
    #   
modules/ml/src/main/java/org/apache/ignite/ml/nn/MLPGroupUpdateTrainerCacheInput.java
    #   
modules/ml/src/main/java/org/apache/ignite/ml/nn/trainers/distributed/MLPGroupUpdateTrainingData.java
    #   
modules/ml/src/main/java/org/apache/ignite/ml/nn/trainers/distributed/MLPGroupUpdateTrainingLoopData.java
    #   
modules/ml/src/main/java/org/apache/ignite/ml/optimization/updatecalculators/SimpleGDParameter.java
    #   
modules/ml/src/main/java/org/apache/ignite/ml/trainers/local/package-info.java
    #   modules/ml/src/main/java/org/apache/ignite/ml/util/Utils.java
    #   
modules/ml/src/test/java/org/apache/ignite/ml/nn/MLPGroupTrainerTest.java

commit d34e2c7185c2f9a309fd7e8d9fdb6ef6aea1ea6a
Author: Artem Malykh <amalykh@...>
Date:   2018-01-17T16:33:06Z

    IGNITE-7456: Rolled back paths to mnist.

commit 2d98abfe94a7a80ed58ad0a00944ee95a4c749f2
Author: Artem Malykh <amalykh@...>
Date:   2018-01-17T16:33:45Z

    IGNITE-7456: Reformatted javadoc.

----


> Fix wrong batch logic in distributed MLP training.
> --------------------------------------------------
>
>                 Key: IGNITE-7456
>                 URL: https://issues.apache.org/jira/browse/IGNITE-7456
>             Project: Ignite
>          Issue Type: Bug
>          Components: ml
>    Affects Versions: 2.4
>            Reporter: Artem Malykh
>            Assignee: Artem Malykh
>            Priority: Major
>             Fix For: 2.4
>
>
> Batch for training is created outside of training loop, therefore in each 
> local step we work with the same batch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to