[
https://issues.apache.org/jira/browse/IGNITE-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370777#comment-16370777
]
ASF GitHub Bot commented on IGNITE-7660:
----------------------------------------
GitHub user Andy92 opened a pull request:
https://github.com/apache/ignite/pull/3548
IGNITE-7660: Refactor LSQR algorithm
Refactor for the issue ignite-7660.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Andy92/ignite master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3548
----
commit 8fee202a0594416e8975919f49de19e8fc68b5bd
Author: Andy <andyy@...>
Date: 2018-02-20T23:49:50Z
IGNITE-7660: Refactor LSQR algorithm
----
> Refactor LSQR algorithm
> -----------------------
>
> Key: IGNITE-7660
> URL: https://issues.apache.org/jira/browse/IGNITE-7660
> Project: Ignite
> Issue Type: Improvement
> Components: ml
> Reporter: Anton Dmitriev
> Priority: Minor
>
> This issues is the nest step of the IGNITE-7438 task.
> In the IGNITE-7438 the AbstractLSQR implementation has been copied from the
> SciPy implementation which has been copies from another old implementation.
> As result the code in the
> [AbstractLSQR|https://github.com/apache/ignite/blob/master/modules/ml/src/main/java/org/apache/ignite/ml/math/isolve/lsqr/AbstractLSQR.java]
> looks a bit weird. All variables have meaningless names and the whole
> algorithm written as the one method.
> The goal of this task is to refactor the LSQR code and:
> * Make variable names more meaningful.
> * Add comments to the variables and result (see
> [LSQRResult|https://github.com/apache/ignite/blob/master/modules/ml/src/main/java/org/apache/ignite/ml/math/isolve/lsqr/LSQRResult.java]).
> * Move parts of the algorithm into separate methods where it's appropriate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
