[ https://issues.apache.org/jira/browse/IGNITE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449558#comment-16449558 ]
Ivan Rakov commented on IGNITE-5151: ------------------------------------ [~vinx13], github reports merge conflicts. Please merge fresh master into your branch. Also, I'd optimize the check by "double-checked locking" - there's no need to acquire monitor on every ensureFreeSpace method call: {noformat} /** * Warns on first eviction. */ private void warnFirstEvict(MemoryPolicyConfiguration plcCfg) { if (warnFirstEvict) return; synchronized (this) { if (firstEvictWarn) return; firstEvictWarn = true; } U.warn(log, "Page-based evictions started." + " You may wish to increase 'maxSize' on page memory policy: " + plcCfg.getName()); } {noformat} > Add some warning when offheap eviction occurs > --------------------------------------------- > > Key: IGNITE-5151 > URL: https://issues.apache.org/jira/browse/IGNITE-5151 > Project: Ignite > Issue Type: Improvement > Affects Versions: 2.0 > Reporter: Ksenia Rybakova > Assignee: Wuwei Lin > Priority: Major > > Currently if offheap eviction occurs we are silently losing data. It whould > be helpful to have some warning in log as it's done for onheap eviction. -- This message was sent by Atlassian JIRA (v7.6.3#76005)