[
https://issues.apache.org/jira/browse/IGNITE-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470691#comment-16470691
]
Dmitriy Pavlov commented on IGNITE-8266:
----------------------------------------
[~NIzhikov], according to my feeling of "Apache way", we should come to an
agreement here and only then apply the patch.
I suggest to move deletion of super.afterTestsStopped() out of scope by 2
reasons..
# First of all after applying patch without such removal less test will start
to fail. Clean up after test may cause flaky failures, so I prefer to move by
smaller steps. It will be easier to identify failure reason.
# afterTestsStopped() may now contain no-op code, but some time later, base
class may be changed, so new base class will require additional cleanup. E.g.
non persistence Ignite test can be transformed to persistence enabled, so call
to super would become reasonable. Same for system options setupa and cleanup.
System option which was forgotten to be reset can cause a number of
non-intuitive flaky failures.
I, of course , can proceed with review, but would like to enlist your support
in final solution.
> Remove afterTestsStopped method due to stopAllGrids by default
> --------------------------------------------------------------
>
> Key: IGNITE-8266
> URL: https://issues.apache.org/jira/browse/IGNITE-8266
> Project: Ignite
> Issue Type: Sub-task
> Affects Versions: 2.5
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Minor
> Labels: test
> Fix For: 2.6
>
>
> Remove this types of method from test in whole ignite-core module.
> {code:java}
> @Override protected void afterTestsStopped() throws Exception {
> super.afterTestsStopped();
> stopAllGrids();
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
