[ https://issues.apache.org/jira/browse/IGNITE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471761#comment-16471761 ]
Amelchev Nikita edited comment on IGNITE-172 at 5/11/18 11:29 AM: ------------------------------------------------------------------ *1. GridTcpCommunicationSpiRecoveryAckSelfTest.testQueueOverflow* It test is OK. [Test history.|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-7087354412440633390&tab=testDetails] It has 1 fail where most of spi tests were broken. *2. GridTcpCommunicationSpiTcpNoDelayOffSelfTest.testSendToManyNodes* It test is good too. [Test history.|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=1831896094370683279&tab=testDetails] *3. IgniteTcpCommunicationRecoveryAckClosureSelfTest.testQueueOverflow* It test is not ok and I prepare PR that fixed it. The test was failed because of ack closure don't apply by idle timeout (Timeout in the test is 5s, but idle timeout is 60s). I have decreased idle timeout to 2s. Test sends 251 messages and by ackThreshold(5) it doesn't apply too. I increased the count of messages as it done in GridTcpCommunicationSpiRecoveryAckSelfTest.testQueueOverflow() for guarantee queue overflow. But I set it to 1279, that count of all sent messages will in proportion to ackThreshold for test completion by ackThreshold. If test throws an exception on sending a message it will be checked applying closure by idle timeout. I run it [1000 times on TC|https://ci.ignite.apache.org/viewLog.html?buildId=1283301&buildTypeId=IgniteTests24Java8_Spi&tab=testsInfo] and it OK. was (Author: nsamelchev): *1. GridTcpCommunicationSpiRecoveryAckSelfTest.testQueueOverflow* It test is OK. [Test history.|[https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-7087354412440633390&tab=testDetails]] It has 1 fail where most of spi tests were broken. *2. GridTcpCommunicationSpiTcpNoDelayOffSelfTest.testSendToManyNodes* It test is good too. [Test history.|[https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=1831896094370683279&tab=testDetails]] *3. IgniteTcpCommunicationRecoveryAckClosureSelfTest.testQueueOverflow* It test is not ok and I prepare PR that fixed it. The test was failed because of ack closure don't apply by idle timeout (Timeout in the test is 5s, but idle timeout is 60s). I have decreased idle timeout to 2s. Test sends 251 messages and by ackThreshold(5) it doesn't apply too. I increased the count of messages as it done in GridTcpCommunicationSpiRecoveryAckSelfTest.testQueueOverflow() for guarantee queue overflow. But I set it to 1279, that count of all sent messages will in proportion to ackThreshold for test completion by ackThreshold. If test throws an exception on sending a message it will be checked applying closure by idle timeout. I run it [1000 times on TC|https://ci.ignite.apache.org/viewLog.html?buildId=1283301&buildTypeId=IgniteTests24Java8_Spi&tab=testsInfo] and it OK. > [Test] [Rare] GridTcpCommunicationSpiRecoveryAckSelfTest and > IgniteTcpCommunicationRecoveryAckClosureSelfTest > ------------------------------------------------------------------------------------------------------------- > > Key: IGNITE-172 > URL: https://issues.apache.org/jira/browse/IGNITE-172 > Project: Ignite > Issue Type: Bug > Components: general > Affects Versions: 1.5.0.final > Reporter: Irina Vasilinets > Assignee: Amelchev Nikita > Priority: Major > Labels: MakeTeamcityGreenAgain, Muted_test > > GridTcpCommunicationSpiRecoveryAckSelfTest.testQueueOverflow and > GridTcpCommunicationSpiTcpNoDelayOffSelfTest.testSendToManyNodes > fail sometimes. > IgniteTcpCommunicationRecoveryAckClosureSelfTest.testQueueOverflow - 1 from 10 -- This message was sent by Atlassian JIRA (v7.6.3#76005)